231181 – gtkpod-0.99.8-21: comparison with string literal

Bug 231181 - gtkpod-0.99.8-21: comparison with string literal

Summary: gtkpod-0.99.8-21: comparison with string literal

Status:	RESOLVED DUPLICATE of bug 233655

Alias:	None

Product:	openSUSE 10.3
Classification:	openSUSE
Component:	Basesystem (show other bugs)
Version:	unspecified
Hardware:	All SUSE Other

Priority:	P5 - None Severity: Normal (vote)
Target Milestone:	---
Assignee:	Petr Gajdos
QA Contact:	E-mail List

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Clone This Bug

Reported:	2006-12-30 20:30 UTC by David Binderman
Modified:	2007-04-18 12:06 UTC (History)
CC List:	0 users

See Also:
Found By:	Other
Services Priority:
Business Priority:
Blocker:	---
Marketing QA Status:	---
IT Deployment:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Binderman 2006-12-30 20:30:21 UTC

I just tried to compile package gtkpod-0.99.8-21

The compiler said

mp3file.c:1153: warning: comparison with string literal

The source code is

    if (frame_name == ID3_FRAME_GENRE)

but

linux:/usr/src/packages/SPECS # find /usr/include -name \*.h -print | xargs fgrep ID3_FRAME_GENRE
/usr/include/id3tag.h:# define ID3_FRAME_GENRE  "TCON"

Suggest new code

    if (strcmp( frame_name, ID3_FRAME_GENRE) == 0)

Comment 1 Stefan Dirsch 2007-01-16 22:30:36 UTC

Feel free to close as duplicate of Bug #233655.

Comment 2 Petr Gajdos 2007-04-18 12:06:53 UTC

Fixed.

*** This bug has been marked as a duplicate of bug 233655 ***