Bug 366361 - filepath entered in location bar should be loaded after user press 'enter'
Summary: filepath entered in location bar should be loaded after user press 'enter'
Status: RESOLVED FIXED
Alias: None
Product: openSUSE 11.0
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Alpha 2
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Federico Mena Quintero
QA Contact: E-mail List
URL:
Whiteboard: gnomeup-nautilus
Keywords:
Depends on:
Blocks: filechooser-tracker
  Show dependency treegraph
 
Reported: 2008-03-01 11:08 UTC by Pacho Ramos
Modified: 2008-04-18 16:39 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos 2008-03-01 11:08:37 UTC
I have read http://www.gnome.org/~federico/news-2008-02.html#29 and I think that would be nice get this problem fixed. This was already reported to upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=505857

With a suggested patch, but seems that there is no activity on it for now.

I reproduce here the upstream summary:

Currently, when user enter a file path in the location bar in filechooser, the
contents will not refresh after user pressing 'enter' key, although it can be
workaround to clock on the 'Ok' button. 

Some gnome applications such as gedit implemented their own filechooser, which
has this functionality. 

I don't know if there is any special reason why we don't implement this feature
on filechooser as I think this is very useful. and only 4 lines of codes need
to be added. 

Can some one provide some feedback on why we don't do this.

Other information:
This is a suggested fix for this bug

--- gtk/gtkfilechooserdialog.c.orig     2007-10-16 21:20:38.000000000 +0800
+++ gtk/gtkfilechooserdialog.c  2007-12-27 16:20:18.388325000 +0800
@@ -465,6 +465,12 @@
     {
       response_id = va_arg (varargs, gint);
       gtk_dialog_add_button (GTK_DIALOG (result), button_text, response_id);
+     
+      if ((response_id == GTK_RESPONSE_OK) ||
+         (response_id == GTK_RESPONSE_ACCEPT) ||
+         (response_id == GTK_RESPONSE_YES) ||
+         (response_id == GTK_RESPONSE_APPLY))
+              gtk_dialog_set_default_response (GTK_DIALOG (result),
response_id);
       button_text = va_arg (varargs, const gchar *);
     }

_____

I have noticied that this affects to apps like brasero (http://bugzilla.gnome.org/show_bug.cgi?id=465175) and gnome-appearance-properties

Thanks a lot for get this fixed :-) (would be nice get this fixed also for upstream)
Comment 1 Federico Mena Quintero 2008-04-18 16:39:07 UTC
This is in now in gtk2-2.12.9 for openSUSE 11.0.  Thanks for the reminder :)