Bugzilla – Bug 368704
mdadm can't hot-add devices larger than 4TB
Last modified: 2008-07-31 16:16:49 UTC
Hallo, there is a serious bug in mdadm version 2.6.2 that is said to be fixed by the main developper: http://marc.info/?l=linux-raid&m=120486150404387&w=2 It prevents an exchanged disk to be put in a RAID1 again. (at least in our huge setup 13TB) Thanks Lars
openSUSE 10.3 is released, "blocker" makes little sense here.
Neil, could you please point me to the 2.6.3 fix? I found this in the 2.6.3 changelog: http://neil.brown.name/git?p=mdadm;a=commit;h=005debfc11b4cbe653503667423df98b64e5be0e, but it seems to only affect 1.[12] metadata. Or is it the fix you referred to? thanks!
That was the patch I was thinking of. As you say, it does not apply in this case. It seems I mis-diagnosed the problem. I now think the problem is that in Manage.c, this code if (ldsize/512 < array.size) { fprintf(stderr, Name ": %s not large enough to join array\n", dv->devname); return 1; } is incorrect because "array.size" is an "int", and ldsize/512 is larger than 2^32. That will need a big of thought to fix up properly. I'll try to have something by early next week.
Created attachment 204181 [details] Patch to fix Sorry for the delay. This patch should fix the problem.
Neil: thanks for the patch! Lars: can you please try patched mdadm from http://download.opensuse.org/repositories/home:/michal-m:/test/openSUSE_10.3/ ? Thanks.
Adjusting the summary a bit, was "bug in mdadm version v2.6.2 already fixed in v2.6.3".
Lars wrote: Hallo Michal, hallo Neil at first attempt i got this: monosan:~ # rpm -i mdadm-2.6.2-5.1.x86_64.rpm warning: mdadm-2.6.2-5.1.x86_64.rpm: Header V3 DSA signature: NOKEY, key ID 48514c1d package mdadm-2.6.2-16 (which is newer than mdadm-2.6.2-5.1) is already installed file /sbin/mdadm from install of mdadm-2.6.2-5.1 conflicts with file from package mdadm-2.6.2-16 file /sbin/raidautorun from install of mdadm-2.6.2-5.1 conflicts with file from package mdadm-2.6.2-16 Then I forced: monosan:~ # rpm --force -i mdadm-2.6.2-5.1.x86_64.rpm warning: mdadm-2.6.2-5.1.x86_64.rpm: Header V3 DSA signature: NOKEY, key ID 48514c1d Updating etc/sysconfig/mdadm... monosan:~ # mdadm -C /dev/md8 -l 1 -n2 /dev/monosan/test0 /dev/duosan/test1 mdadm: Defaulting to verion 1.0 metadata mdadm: array /dev/md8 started. monosan:~ # mdadm /dev/md8 -f /dev/duosan/test1 mdadm: set /dev/duosan/test1 faulty in /dev/md8 monosan:~ # mdadm /dev/md8 -r /dev/duosan/test1 mdadm: hot removed /dev/duosan/test1 monosan:~ # mdadm /dev/md8 -a /dev/duosan/test1 mdadm: re-added /dev/duosan/test1 monosan:~ # blockdev --getsize /dev/md8 17179868912 So I can confirm that the array can be repaired again with it being bigger than 4TB (actually 8TB). There still is a small typo left: »mdadm: Defaulting to verion 1.0 metadata« ^^^^^^ Thank you and Neil Best regards. Lars
Neil, is it OK to use the patch as is for an online update? I'm curious because it isn't yet in your mdadm git repo. Thanks! Michal
Neil, *ping*?
Sorry, I was away on leave. I've just push that patch (and others) into my git repo. Yes, it is safe to use immediately.
Submitted fixed packages for 10.3 and SLES10
patchinfo mentions SLES10 package has been submitted to SLES10-SP2 where should this be fixed ? both ?
update released for 10.3
released