Bug 385149 - krandrtray don't rotate wacom tablet devices on TabletPCs
Summary: krandrtray don't rotate wacom tablet devices on TabletPCs
Status: RESOLVED FIXED
: 347631 408745 (view as bug list)
Alias: None
Product: openSUSE 11.0
Classification: openSUSE
Component: KDE4 Workspace (show other bugs)
Version: Beta 1
Hardware: Other Other
: P4 - Low : Normal (vote)
Target Milestone: ---
Assignee: Stephan Binner
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on: 409366
Blocks: 409526
  Show dependency tree / graph
 
Reported: 2008-04-30 09:55 UTC by Danny Al-Gaaf
Modified: 2008-08-01 15:38 UTC (History)
3 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
patch to fix rotation in krandrtray (10.26 KB, patch)
2008-07-15 20:25 UTC, Danny Al-Gaaf 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Danny Al-Gaaf 2008-04-30 09:55:13 UTC 
Affected are: KDE3 and KDE4 on 11.0 and KDE3 on 10.3 as it looks to me.

As described in the documentation and in Fate #300713 KDE should be able to rotate the wacom input devices if the screen get rotated via randr extension. Unfortunately the related patch in the KDE3 package (kdebase3) is disabled. Please enable the patch (rotate-wacom-pointers.diff) again and update kde4 to be able to rotate wacom input devices.
Comment 1 Stephan Binner 2008-04-30 10:23:06 UTC 
Don't be silly.
Comment 2 Danny Al-Gaaf 2008-04-30 10:40:09 UTC 
Sorry, but I'm not silly. It's a requested, documented and needed feature!
Comment 3 Danny Al-Gaaf 2008-04-30 10:43:31 UTC 
And btw. I don't know who disabled the patch, but there is no comment in the Changelog about it.
Comment 4 Stephan Binner 2008-05-14 08:24:24 UTC 
http://lists.opensuse.org/opensuse-commit/2007-08/msg00473.html disabled it.

Ported/reenabled for kdebase3.
Comment 5 Stephan Binner 2008-05-14 09:04:26 UTC 
Ported/added to kdebase4-workspace too. Didn't test functionality though, I'm sure you will do :-)...
Comment 6 Danny Al-Gaaf 2008-07-11 20:04:57 UTC 
I've tried the current 11.0 (KDE3) package again and it looks as if don't work. 

I've added some qdebug/fprintf calls to the code in legacyrandrscreen.cpp but I don't get any debug from there. Also ltrace/strace shows that xsetwacom get never called. Looks as if the port didn't work as expected.
Comment 7 Danny Al-Gaaf 2008-07-13 22:27:49 UTC 
*** Bug 408745 has been marked as a duplicate of this bug. ***
Comment 8 Danny Al-Gaaf 2008-07-14 02:25:19 UTC 
*** Bug 408745 has been marked as a duplicate of this bug. ***
Comment 9 Danny Al-Gaaf 2008-07-15 20:24:35 UTC 
Dirk found out that the code is never called because of xrandr v1.2. He tried to fix it by adding the same code to the RandRScreen class, but didn't work for me on any TabletPC.

I added the code after some debugging also to RandRCrtc and now it works. I attach an updated patch including the changes from Dirk and me.

Can we make a YOU update?
Comment 10 Danny Al-Gaaf 2008-07-15 20:25:35 UTC 
Created attachment 227931 [details]
patch to fix rotation in krandrtray
Comment 11 Stefan Behlert 2008-07-15 20:48:18 UTC 
I would like to have this fixed, but Coolo has the final decision....
Comment 12 Stephan Kulow 2008-07-17 11:15:39 UTC 
actually anja has. I would think there aren't that many tabletpc users for openSUSE, but if it's critical to them, let's do an update
Comment 14 Dirk Mueller 2008-07-18 13:30:42 UTC 
*** Bug 347631 has been marked as a duplicate of this bug. ***
Comment 15 Dirk Mueller 2008-07-29 14:34:23 UTC 
submitted as online update.
Comment 16 Anja Stock 2008-08-01 15:38:04 UTC 
released