Bug 419159 - sax2: YaST2 keyboard without display testing
Summary: sax2: YaST2 keyboard without display testing
Status: RESOLVED DUPLICATE of bug 389072
Alias: None
Product: openSUSE 11.1
Classification: openSUSE
Component: SaX2 (show other bugs)
Version: Factory
Hardware: Other Other
: P5 - None : Enhancement (vote)
Target Milestone: ---
Assignee: Stefan Dirsch
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-21 11:38 UTC by Karl Eichwalder
Modified: 2008-08-27 02:39 UTC (History)
1 user (show)

See Also:
Found By: Documentation
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Eichwalder 2008-08-21 11:38:26 UTC 
I think there is not need to test the display configuration, if the user changes the keyboard layout only.  To reproduce:

Click "Keyboard Layout" in the YaST CC (gtk).  SaX2 starts with the Keyboard Properties dialog.

Change "Layout" from English to German.

Click "OK".  Now a message pop-up wants you to test the configuration which is superfluous, I'd say.
Comment 1 Stefan Dirsch 2008-08-21 11:53:30 UTC 
Makes sense to me. Marcus, how to implement this?
Comment 2 Marcus Schaefer 2008-08-21 13:29:56 UTC 
you need to make the last message more "intelligent". Normally sax2 is
called as complete application but it also can be called with only a
specific dialog. In case of a specific dialog it might be better to have
a specific last message too.

1) Take a look at api/frame.cpp

void SCCFrame::slotFinish ( void ) {   
    ...
}

this is the code which displays the message when ok is clicked

2) the variable 

   mRequestedDialog

contains the dialog if one was requested. You can adapt the slotFinish
function to handle the mRequestedDialog information and display different
messages here

Be aware that you need to introduce new texts and this also requires a
new pot file in the localization repository
Comment 3 Stefan Dirsch 2008-08-21 14:52:50 UTC 
Thanks!
Comment 4 Stefan Dirsch 2008-08-27 02:39:26 UTC 
This issue becomes obsolete with the proposal in Bug #389072, comment #9.

*** This bug has been marked as a duplicate of bug 389072 ***