Bug 440835 - openbabel-2.2.0-4.40: missing return statement
Summary: openbabel-2.2.0-4.40: missing return statement
Status: RESOLVED DUPLICATE of bug 442933
Alias: None
Product: openSUSE 11.1
Classification: openSUSE
Component: KDE4 Workspace (show other bugs)
Version: Factory
Hardware: All openSUSE 11.0
: P4 - Low : Minor (vote)
Target Milestone: ---
Assignee: E-mail List
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-01 14:29 UTC by David Binderman
Modified: 2009-03-17 17:38 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2008-11-01 14:29:43 UTC 
I just tried to build the OpenSuse factory package openbabel-2.2.0-4.40
and the compiler said

mmcifformat.cpp:147: warning: no return statement in function returning non-void

The source code is

    CIFResidueID & operator=(const CIFResidueID & other)
      {
      ChainNum = other.ChainNum;
      ResNum = other.ResNum;
      }

Suggest code rework.
Comment 1 Lubos Lunak 2009-02-05 17:48:38 UTC 
.

*** This bug has been marked as a duplicate of bug 442933 ***
Comment 2 David Binderman 2009-03-05 11:30:08 UTC 
(In reply to comment #1)
> *** This bug has been marked as a duplicate of bug 442933 ***

I just checked version 2.2.0-4.81 of openbabel, some four months later,
and the code is still broken.
Comment 3 Forgotten User vXTZVacoSi 2009-03-05 12:02:59 UTC 
David this stuff is not openSUSE related, please tell this the guys from openbabel, opensuse is not responsible for fixing compiler warnings in upstream code...
Comment 4 David Binderman 2009-03-05 15:58:02 UTC 
(In reply to comment #3)
> opensuse is not responsible for fixing compiler warnings in upstream code...

So why do most opensuse folks fix compiler warnings in upstream code, then ?

I've never really understood the opensuse policy on bugs.

Yes the opensuse front pages continue to ask for bug reports, but 
about one developer in ten just refuses to make the fix.

Oh well - 90% is pretty good, 95% would be better.
Comment 5 Lubos Lunak 2009-03-17 17:38:03 UTC 
See http://en.opensuse.org/Bugs:KDE#Report_at_bugzilla.novell.com_or_bugs.kde.org.3F for the policy on handling KDE bugreports at openSUSE.

Specifically for your compiler checks bugreports, you are just wasting time of busy people on very minor issues. If you reported these directly to the relevant projects, it would be almost the same work for you, and openSUSE developers would not have to repeat your work of reporting a problem.