Bug 514376 - ktorrent-3.2.2-1.4: 2 * undefined code
Summary: ktorrent-3.2.2-1.4: 2 * undefined code
Status: RESOLVED DUPLICATE of bug 442933
Alias: None
Product: openSUSE 11.2
Classification: openSUSE
Component: Other (show other bugs)
Version: Factory
Hardware: All openSUSE 11.1
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: E-mail List
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-18 13:33 UTC by David Binderman
Modified: 2009-06-22 13:55 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2009-06-18 13:33:01 UTC 
I just tried to build factory package ktorrent-3.2.2-1.4
The build said

1.

/usr/src/packages/BUILD/ktorrent-3.2.2/libbtcore/torrent/timeestimator.cpp:208:29: warning: operation on '((bt::SampleQueue*)this)->bt::SampleQueue::m_end' may be undefined

The source code is

                m_end = (++m_end) % m_size;

I agree with the compiler - the code is undefined.
Suggest new code

                m_end = (m_end + 1) % m_size;

2.

/usr/src/packages/BUILD/ktorrent-3.2.2/libbtcore/torrent/timeestimator.cpp:210:33: warning: operation on '((bt::SampleQueue*)this)->bt::SampleQueue::m_start' may be undefined

Duplicate.
Comment 1 Lubos Lunak 2009-06-22 13:55:43 UTC 
.

*** This bug has been marked as a duplicate of bug 442933 ***