Bug 515024 - kradio-1.0beta3b_20060920-226.5: 2 * bad call to delete
Summary: kradio-1.0beta3b_20060920-226.5: 2 * bad call to delete
Status: RESOLVED DUPLICATE of bug 442933
Alias: None
Product: openSUSE 11.2
Classification: openSUSE
Component: KDE4 Applications (show other bugs)
Version: Factory
Hardware: All openSUSE 11.1
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: E-mail List
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-21 09:05 UTC by David Binderman
Modified: 2009-06-22 18:07 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2009-06-21 09:05:29 UTC
I just had a look at factory package kradio-1.0beta3b_20060920-226.5
In file kradio3/plugins/recording/encoder_ogg.cpp, around line 125
is the code

static void vorbis_comment_add_tag_new(vorbis_comment *vc, const QString &tag, const QString &value)
{
    char *stag   = strdup(tag.ascii());
    char *svalue = strdup(value.utf8());
    vorbis_comment_add_tag(vc, stag, svalue);
    delete stag;
    delete svalue;
}

The return value from strdup should be freed by calling free(), not
by calling delete.

Suggest code rework.
Comment 1 Lubos Lunak 2009-06-22 13:32:36 UTC
http://kradio.sourceforge.net/

*** This bug has been marked as a duplicate of bug 442933 ***
Comment 2 Forgotten User h8XpMSaN1v 2009-06-22 18:07:31 UTC
Hi all!
This bug is fixed in the trunk of the KRadio SVN (r949). It will be part of KRadio 4.0.1. However, 4.0.1 will need a bit more time for testing and bug fixing since the ALSA device selection has been
reworked and because I'm currently quite busy with other stuff. Please have a look at https://bugzilla.novell.com/show_bug.cgi?id=500021.
BR, Martin