Bugzilla – Bug 522660
more information in package change / project change / package updated requests
Last modified: 2016-02-10 16:16:04 UTC
We need more information in the package / project changed and updated request. This is two parts: - bs_srcserver needs to send more information to Hermes - Hermes template needs to include this data. Its probably possible to diff the XML before/after. (not text diff, but some other diff method).
i could send patches if you tell me where the VCS repo of the bsserver is ;)
SVN URL: https://forgesvn1.novell.com/svn/opensuse/trunk/buildservice/src/backend Please bear in mind that just an xml diff might be fine for super geeks but not for normal users. Maybe we can come up with something more user friendly? And check first with mls before patching.
i am not thinking of raw xml diffs, this will not be helpful I suspect. more have the XML put into a good visual structure and diff that, or even parse the XML before/after and generate a hand-made difference report.
This a regression and is quite time consuming for packagers -> High prio.
without this no "Normal" user, neither community nor SUSE employee can easily see who changed what and when. The security team requested this in July, it is still not done. Adjust priority to match our requirements.
Please provide a diff without diffing tarballs for source change. Hermes can either 1. get the diff as a parameter provided through the BSHermes call in bs_srcserver 2. or call the API later to get the diff, for that an API call needs to be there and old an new version numbers must be provided through parameters to BSHermes Its up to you how we implement it. For me, option 1. would be more convenient. Since it is a GET request, the size of the diff would be limited to $GET_SIZE_LIMIT (64k?) however. Is that a problem if we diff without tars?
you can still get large diff if you patch large patches
still not done
(In reply to comment #2) > SVN URL: > https://forgesvn1.novell.com/svn/opensuse/trunk/buildservice/src/backend > > Please bear in mind that just an xml diff might be fine for super geeks but not > for normal users. Maybe we can come up with something more user friendly? > > And check first with mls before patching. Status? No change since nearly 2 month while Critical/P1
Good point. Removed me from "Infoprovider" and downgraded to "normal".
Michael, it would certainly help if you could give your opinion on the questions in comment #6. If we have good support in the API, the problem can be solved quickly.
Not diffing tars can be added very easily in the srcserver. I don't know if Marcus can live with that, though.
this biugreport is not about sources, it is about meta data. diffing prettified xml isnt that hard.
Oh, in that case it's not a regression, but just some feature to implement someday. (Comment #6 was about sources)
Yes, and the day I wanted it implemented latest was September 2009.
Maybe, but we can't fulfill every wish. If you really want it you can help us implementing it, right?
I do not really understand what exactly is needed here. We log all changes in a package, we log the submit request number also on each change. Can you tell me which XML you speak about and which information you lack ? Also a use case with (I know X and I want to find out Y) would be helpfull.
I am talking about the mails hermes sends out: Date: Mon, 21 Jun 2010 19:32:17 +0000 From: hermes@opensuse.org To: meissner@novell.com Subject: [obs update] Package aide in security updated X-Mailer: openSUSE Notification System The package aide in security was updated. -- Hermes messaging (http://hermes.opensuse.org) openSUSE Build Service (https://build.opensuse.org/) They need to contain what changed. Same for the project change e-mails.
Note that OBS_PACKAGE_UPDATE only gets sent out if the package META data gets changed. That is probably not what you want. You should subscribe to obs_srcsrv_commit which is the notification that is sent if the package was changed. It comes with a filelist of changes and a ready-to-copy osc command line which shows you the diff. Full diff in the mail is critical atm, because backend diffs over all tarballs. That means the diffs can be huge. As soon as the diffing over tarballs can be avoided, we can add the diff to the mail.
Hermes is obsolete for quite a while now. Hence I close those bugs now, finally.