Bugzilla – Bug 635439
FindGTK2.cmake module is broken with recent version of GTK+
Last modified: 2019-05-22 00:53:59 UTC
In GTK+ 2.21, gdk-pixbuf got split from GTK+. The result is that the include path for gdk-pixbuf is different from the include path from GTK+. And this is causing build failures. Here's a patch I'm adding to yast2-gtk to fix the build there. But we probably want a fix in cmake directly too. This would be the same patch, I guess. Ricardo: I've submitted this to YaST2:Head (sr#46627), but I guess it should probably be committed to svn?
Created attachment 386143 [details] Patch
Thanks for that. Coolo already committed it to svn btw. I kept that FindGTK2 file around because at the time of opensuse 11.2, cmake didn't ship with it. Good it see it has become useful again, but we should definitively get your patch to cmake, so we don't rely on our own FindGTK2.cmake module.
Btw, it seems that you guys uploaded the trunk code to YaST:Head. That's fine, but just to tell, we may have to upload the 11_3 branch again in order to issue a patch: see bug 624310.
Filled up a bug report at cmake: http://public.kitware.com/Bug/view.php?id=11186
Vincent, I've re-uploaded the 11.3 branch code to YaST:HEAD because we are going to issue a patch (bug 624310). (Maybe there's a more elegant way to do this -- is there some YaST:11.3 ? -- but I dunno, so let's momentarily leave it broken.)
Okay, this issue has been addressed upstream: Philip Lowman: "Pushed change into next, should be in first RC for 2.8.3" ( http://public.kitware.com/Bug/view.php?id=11186 ) Philip told me via email your patch was useful, Vincent. Thanks! Petr, should we close the report now?
Thanks for the patch Vincent. I have patched cmake in Factory until cmake-2.8.3 is out. Closing this bug.
Thanks Petr. I've tried the package from the Factory repository, and that one doesn't have the fix in yet. I guess it takes a little bit of time for a submission to get through. Can you tell me what version number of the cmake package should I look out for? http://download.opensuse.org/factory/repo/oss/suse/i586/ Thanks!
By the way, with some help from my buddy google, I've just found a way to make the yast2-gtk build compatible with both 11.3 and Factory. I just have to apply this change to the RPM spec file: - BuildRequires: gdk-pixbuf-devel + %if 0%{?suse_version} > 1130 + BuildRequires: gdk-pixbuf-devel + %endif
(In reply to comment #8) > Thanks Petr. > > I've tried the package from the Factory repository, and that one doesn't have > the fix in yet. I guess it takes a little bit of time for a submission to get > through. Yes, it hasn't been accepted to Factory yet (see request #48122). > Can you tell me what version number of the cmake package should I look out for? The release number will be higher than the current one :) Frankly, I don't know how exactly are those release numbers generated by OBS, so I can't tell you. > http://download.opensuse.org/factory/repo/oss/suse/i586/ You can get the fixed RPM from here: http://download.opensuse.org/repositories/devel:/tools:/building/openSUSE_Factory/i586/
Thx. Will keep an eye on build service: https://build.opensuse.org/request/show/48122