Bug 680140 - AUDIT-0: NetworkManager: polkit-unauthorized-privilege
Summary: AUDIT-0: NetworkManager: polkit-unauthorized-privilege
Status: RESOLVED FIXED
: 691273 (view as bug list)
Alias: None
Product: openSUSE 12.1
Classification: openSUSE
Component: Security (show other bugs)
Version: Factory
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Security Team bot
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 12:59 UTC by Dominique Leuenberger
Modified: 2017-05-15 07:51 UTC (History)
6 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dominique Leuenberger 2011-03-16 12:59:48 UTC
i'm currently preparing Network Manager 0.9 packages (0.8.996) in my branch (cleaning up, preparing for submission to Factory).

The current build fails with

NetworkManager.x86_64: E: polkit-unauthorized-privilege (Badness: 10000) org.freedesktop.NetworkManager.enable-disable-wimax
NetworkManager.x86_64: E: polkit-unauthorized-privilege (Badness: 10000) org.freedesktop.NetworkManager.wifi.share.protected
NetworkManager.x86_64: E: polkit-unauthorized-privilege (Badness: 10000) org.freedesktop.NetworkManager.wifi.share.open
NetworkManager.x86_64: E: polkit-unauthorized-privilege (Badness: 10000) org.freedesktop.NetworkManager.settings.modify.own
NetworkManager.x86_64: E: polkit-unauthorized-privilege (Badness: 10000) org.freedesktop.NetworkManager.settings.modify.system

which requires modification on the polkit default privileges.

Anything else I can provide to smooth this change?
Comment 1 Ludwig Nussel 2011-03-16 13:03:01 UTC
we should take a look but I'll add the privileges already so you can build your package without rpmlintrc
Comment 2 Dominique Leuenberger 2011-03-16 13:14:28 UTC
Thank you very much Ludwig.

for reference: the package is currently in home:dimstar:branches:GNOME:Factory > NetworkManager  (in preparation of the entire NM stack)
Comment 3 Vincent Untz 2011-04-21 10:16:18 UTC
There's also a suse-dbus-unauthorized-service error, I guess, since it got added to rpmlintrc for now.
Comment 4 Vincent Untz 2011-05-02 12:33:10 UTC
Ludwig: I see polkit-default-privs has been updated for the comment 0.

However, I still have this one which was missing in the report:
NetworkManager.i586: I: polkit-unauthorized-privilege (Badness: 10000) org.freedesktop.NetworkManager.settings.modify.hostname

Also, this polkit-default-privs sounds wrong:

org.freedesktop.NetworkManager.settings.modify.own              auth_admin

This means that I have to enter the root password to modify my own connections (not the system-wide ones). Do you want me to file a new bug for that?
Comment 5 Ludwig Nussel 2011-05-02 12:42:30 UTC
(In reply to comment #4)
> Ludwig: I see polkit-default-privs has been updated for the comment 0.
> 
> However, I still have this one which was missing in the report:
> NetworkManager.i586: I: polkit-unauthorized-privilege (Badness: 10000)
> org.freedesktop.NetworkManager.settings.modify.hostname

Ok, will add.

> Also, this polkit-default-privs sounds wrong:
> 
> org.freedesktop.NetworkManager.settings.modify.own              auth_admin
> 
> This means that I have to enter the root password to modify my own connections
> (not the system-wide ones). Do you want me to file a new bug for that?

I thought NM 0.9 now finally makes all connections system
connections?
Anyways, setting something to 'yes' should get a security review first.
Comment 6 Vincent Untz 2011-05-02 12:57:36 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Also, this polkit-default-privs sounds wrong:
> > 
> > org.freedesktop.NetworkManager.settings.modify.own              auth_admin
> > 
> > This means that I have to enter the root password to modify my own connections
> > (not the system-wide ones). Do you want me to file a new bug for that?
> 
> I thought NM 0.9 now finally makes all connections system
> connections?

By default, yes. But I think this is wrong and I'm trying to get this changed upstream, see https://bugzilla.gnome.org/show_bug.cgi?id=646187#c12 (an example where this is wrong is the Novell wireless network, which uses the authentication data is really per-user, and it's wrong to create a system-wide connection for that).

> Anyways, setting something to 'yes' should get a security review first.

Nod, makes sense. Are you happy to keep this in this bug?
Comment 7 Ludwig Nussel 2011-05-02 14:30:29 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Also, this polkit-default-privs sounds wrong:
> > > 
> > > org.freedesktop.NetworkManager.settings.modify.own              auth_admin
> > > 
> > > This means that I have to enter the root password to modify my own connections
> > > (not the system-wide ones). Do you want me to file a new bug for that?
> > 
> > I thought NM 0.9 now finally makes all connections system
> > connections?
> 
> By default, yes. But I think this is wrong and I'm trying to get this changed
> upstream, see https://bugzilla.gnome.org/show_bug.cgi?id=646187#c12 (an example
> where this is wrong is the Novell wireless network, which uses the
> authentication data is really per-user, and it's wrong to create a system-wide
> connection for that).

Ugh. Not so fast please :-) per-user connections do not actually
exist. That is something NM made up for years. Network connections,
nameserver settings, routing tables etc are all system wide. I'm
glad to see those broken user connections gone.
I agree that storing the credentials alongside the connection
settings in plaintext in e.g. /etc/ might not be a good idea in
every case though. I'd expect NM to simply prompt the user who
activated the connection for missing credentials then. That's how
smpppd works for example.

> > Anyways, setting something to 'yes' should get a security review first.
> 
> Nod, makes sense. Are you happy to keep this in this bug?

Sure.
Comment 8 Bernhard Wiedemann 2011-05-02 15:00:22 UTC
This is an autogenerated message for OBS integration:
This bug (680140) was mentioned in
https://build.opensuse.org/request/show/69227 Factory / polkit-default-privs
Comment 9 Vincent Untz 2011-05-30 09:51:46 UTC
About org.freedesktop.NetworkManager.settings.modify.own: the only thing I can tell is that every time I want to connect to wifi/vpn with a password, I have to enter the root password. So that's really something that won't work in a released version.
Comment 10 Bruno Friedmann 2011-05-30 11:21:58 UTC
+1 for C9 

What we will propose to admins, that will never give root password of a computer.
Comment 11 Hans-Peter Holler 2011-06-15 20:16:21 UTC
It's even worse with KDE (see https://bugzilla.novell.com/show_bug.cgi?id=691273)
Yes, there is a functional network, but with ethernet only!

So, a white cross with an red background is a cosmetic symptom when you are wired, but no chance with plasmoid-networkmanagement and wireless connections since plasmoid-networkmanagement has no fallback to give root password.

For the time being I can live with nm-applet.

But please review polkit, dbus or what ever to give us back seamless wireless connections.

Marking https://bugzilla.novell.com/show_bug.cgi?id=691273 as duplicate.
Comment 12 Hans-Peter Holler 2011-06-15 20:19:32 UTC
*** Bug 691273 has been marked as a duplicate of this bug. ***
Comment 13 Ludwig Nussel 2011-07-28 09:47:27 UTC
So I finally got a Laptop I could install current Factory on. I tried connecting to a WPA2 enterprise network. The implementation looks rather broken/buggy. NM seems to require PK authentication for the wrong action and presents the wrong dialogs. When a system connection is created with the option to always prompt for the password I would not expect requiring root authentication from the user to actually enter it. Also, presenting the full connection edit dialog instead of just a password prompt is rather confusing. This needs to be fixed in NM and has nothing to do with the default privilege setting.
Comment 14 David Kerkhof 2011-08-13 17:15:27 UTC
I run into the same problem, needing the root password when trying to connect wifi. Worked around that by creating politkit rules, that fixed it for me, but networkmanager won't connect automatically, I need to connect manually to a wifi network, whereas this used to work without any problem on previous opensuse releases
Comment 15 Ludwig Nussel 2011-08-23 07:23:22 UTC
I've filed bug 713639 now to track the unneeded authentication requests..
Comment 16 David Kerkhof 2011-09-03 19:06:11 UTC
Just a little comment, I read the page from the link of comment 6. I use an encrypted home which gives me the possibility to use kwallet without password and know the wpa passwords of all the places I visit, both private and work related places. Reading that wpa passwords will possibly be stored unencrypted in /etc worries me because I want those passwords safe in case my laptop ever gets stolen. For me the only acceptable place is in some wallet, and the way it used to work with knetworkmanager and kwallet worked fine for me. Now I have to give a root password to create a new connection, for me a nuisance, for my wife on her laptop impossible because she doesn't know the root password. Please take these things into consideration with the next versions of opensuse!
Comment 17 Sebastian Krahmer 2017-05-15 07:51:36 UTC
As per audit-team discussion, we are closing this old issue as solved.
If theres newer versions to check with, please open new bug for it.