Bug 779048 - Hibernation doesnt work with splash enabled
Summary: Hibernation doesnt work with splash enabled
Status: VERIFIED FIXED
: 782817 813868 (view as bug list)
Alias: None
Product: openSUSE 12.3
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: x86-64 openSUSE 12.3
: P3 - Medium : Major (vote)
Target Milestone: ---
Assignee: Michael Chang
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 12:48 UTC by Forgotten User JoZGrGEMhM
Modified: 2013-09-27 10:56 UTC (History)
7 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
Hwinfo from my Thinkpad T61 where hibernation doesnt work (805.99 KB, text/plain)
2012-09-06 12:48 UTC, Forgotten User JoZGrGEMhM
Details
Hwinfo from my Samsung R540 where hibernation doesnt work (616.11 KB, text/plain)
2012-09-10 11:43 UTC, Fabian Vogt
Details
splashy-fix-error-no-create-window-support.patch (2.33 KB, patch)
2013-06-28 02:13 UTC, Michael Chang
Details | Diff
missing-current-theme-in-font-path.patch (1.03 KB, patch)
2013-06-28 02:21 UTC, Michael Chang
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Forgotten User JoZGrGEMhM 2012-09-06 12:48:45 UTC
Created attachment 504697 [details]
Hwinfo from my Thinkpad T61 where hibernation doesnt work

User-Agent:       Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.4 (KHTML, like Gecko) Chrome/22.0.1226.0 Safari/537.4 SUSE/22.0.1226.0

I've updated my openSUSE 12.1 to 12.2 and hibernation feature got broken.

When I trying to hibernate my Thinkpad t61 from kde menu or from konsole by pm-hibernate command I get blinking Standby led, blinking hdd led and blinking screen. I'm waiting about 5 minutes - notebook doesnt hibernates and I have to switch it off by powerbutton hold.


Reproducible: Always

Steps to Reproduce:
1.Install or update to 12.2
2.Try to hibernate computer

Actual Results:  
Hiberntion doesnt work

Expected Results:  
Hibernations shoulkd work

I figure out than hibernation works if I set /etc/suspend.conf file  parameter 

splash = n

hwinfo attached
Comment 1 Fabian Vogt 2012-09-10 11:39:40 UTC
I have exactly the same problem (And the solution works perfectly, too).
My System is a Samsung R540 laptop (Intel) (also x86_64) and I can clearly see the splash screen while the screen is flashing. Between the white/splash screens there is some HDD-Activity (Logfiles?) and sometimes can return to the running system by pressing (and holding) backspace and/or escape.
On 12.1 there was only one flash, but a splash screen, too (sleeping tux).
I´ll add my hwinfo here.
Comment 2 Fabian Vogt 2012-09-10 11:43:51 UTC
Created attachment 505017 [details]
Hwinfo from my Samsung R540 where hibernation doesnt work
Comment 3 Stefan Dirsch 2012-09-10 12:59:40 UTC
(In reply to comment #2)
> Created an attachment (id=505017) [details]
> Hwinfo from my Samsung R540 where hibernation doesnt work

That one is an AMD GPU.
Comment 4 Fabian Vogt 2012-09-10 14:19:03 UTC
I cannot find any similarities on both systems (Except Intel).
So I don`t think this is hardware-related (Even with Kernel 3.5.something on 12.1 it worked perfectly). It has something to do with plymouth (or s2disk, don´t know which program is showing the splash) not allowing powering down the graphics card, doesn´t it?
Does somebody know how we could get some logfiles? I can´t find anything s2disk related, /var/log/messages maybe?
Comment 5 Forgotten User --EoyBps8f 2012-09-28 20:32:12 UTC
Bug 782817 includes some logs.
Comment 6 haochuan chen 2013-06-22 20:52:20 UTC
This bug still persists in openSUSE 12.3.
Comment 7 Vojtech Dziewiecki 2013-06-25 06:03:39 UTC
Splash during hibernation is done be package "suspend", which I don't maintain, reassigning.
Comment 8 Vojtech Dziewiecki 2013-06-25 06:06:35 UTC
*** Bug 782817 has been marked as a duplicate of this bug. ***
Comment 10 Michael Chang 2013-06-26 06:01:44 UTC
(In reply to comment #4)
> I cannot find any similarities on both systems (Except Intel).
> So I don`t think this is hardware-related (Even with Kernel 3.5.something on
> 12.1 it worked perfectly). It has something to do with plymouth (or s2disk,
> don´t know which program is showing the splash) not allowing powering down the
> graphics card, doesn´t it?

Maybe. The plymouth is new splash engine for s2disk added since 12.2 from where this issue begins. It did not supersede splashy, in fact splashy is still favored by s2disk, but is broken so that plymouth is chosen.

> Does somebody know how we could get some logfiles? I can´t find anything s2disk
> related, /var/log/messages maybe?

In my case it got logged at vt 8 for s2disk itself and vt 63 for kernel.
Comment 11 Michael Chang 2013-06-26 07:14:59 UTC
(In reply to comment #10)

> Maybe. The plymouth is new splash engine for s2disk added since 12.2 from where
> this issue begins. It did not supersede splashy, in fact splashy is still
> favored by s2disk, but is broken so that plymouth is chosen.

See Also bnc#813868, splashy is broken since 12.2 ..

My idea is either fix broken splashy that things should ideally work like 12.1 or disable it in s2disk as it may have side effects with plymouth (if it didn't do good error handling .. or release the hardware resources).
Comment 12 Michael Chang 2013-06-27 04:07:31 UTC
It turns out to be this DirectFB upstream commit cause the splashy failed to run.

commit e24a8ad788335dd657378318e1a34de74046d9b3
Author: Denis Oliver Kropp <dok@directfb.org>
Date:   Sat Mar 3 14:50:13 2012 +0100

    Core: Don't create a window stack with private layer contexts, no CreateWindow support.

With above patch, the DFBDisplayLayerCooperativeLevel has to explicitly set to 	DLSCL_ADMINISTRATIVE to enable Window support. The splashy omit this step thus it always fail in creating window.

I'm now testing the fix.
Comment 13 Michael Chang 2013-06-28 02:13:25 UTC
Created attachment 546087 [details]
splashy-fix-error-no-create-window-support.patch

As DirectFB not supporting Window creation in private later context since commit e24a8ad, the splashy has to adjust to follow it. 

This patch fixes the problem by not claiming the exclusive(private) access to the primary layer and access it's surface, instead it "creates" shared primary surface and run as windows administrative mode.
Comment 14 Michael Chang 2013-06-28 02:21:18 UTC
Created attachment 546088 [details]
missing-current-theme-in-font-path.patch

Another needed patch from upstream to fix init_font error, after above patch applied.

The patch is related to bnc#664793, by the way.
Comment 15 Michael Chang 2013-06-28 03:01:00 UTC
*** Bug 813868 has been marked as a duplicate of this bug. ***
Comment 16 Michael Chang 2013-06-28 03:45:33 UTC
Testing package is available at

home:michael-chang:bnc779048/splashy

However the testing repo is not yet published ..
Comment 17 Michael Chang 2013-07-01 04:41:33 UTC
Hi Vitaliy, Fabian or haochuan,

Could you please help to test splashy package and see what's happened ?

http://download.opensuse.org/repositories/home:/michael-chang:/bnc779048/openSUSE_12.3/

The splashy should now running instead of plymouth. We may have to know the result to decide what we do next.

THANKS.
Comment 18 Forgotten User 6zm64Jy2Hh 2013-07-01 20:41:09 UTC
Hi Michael

Just to let you know, I tried out the abovementioned packages from your repository and they seem to have fixed the issue on my system. Now I can see the sleeping Tux before the system hibernates and there is no more flickering of the screen. Thank you for looking into this issue. 

You guys are the best!


Cheers

Bertran
Comment 19 haochuan chen 2013-07-02 05:23:52 UTC
(In reply to comment #17)
> Hi Vitaliy, Fabian or haochuan,
> 
> Could you please help to test splashy package and see what's happened ?
> 
> http://download.opensuse.org/repositories/home:/michael-chang:/bnc779048/openSUSE_12.3/
> 
> The splashy should now running instead of plymouth. We may have to know the
> result to decide what we do next.
> 
> THANKS.

I switched to Fedora several days ago, so I have to test it in VirtualBox with 12.3 KDE Live. With your packages the system can hibernate without problems.

THANKS.
Comment 20 Fabian Vogt 2013-07-03 18:40:02 UTC
Also, it works perfectly for me as well!

Thanks, Michael!
Comment 21 Michael Chang 2013-07-04 03:07:27 UTC
Ok. Thanks a lot to the feedback. I have send the fix to splashy package.

SRID#181945.
Comment 22 Bernhard Wiedemann 2013-07-04 10:00:23 UTC
This is an autogenerated message for OBS integration:
This bug (779048) was mentioned in
https://build.opensuse.org/request/show/182156 Factory / splashy
Comment 23 Bernhard Wiedemann 2013-07-05 13:00:09 UTC
This is an autogenerated message for OBS integration:
This bug (779048) was mentioned in
https://build.opensuse.org/request/show/182301 Factory / splashy
Comment 24 Ancor Gonzalez Sosa 2013-09-27 10:56:53 UTC
According to comments, seems to be fixed. Since we are cleaning up old bugs, I will closed it.