Bug 953693 - VLC opens video in a second window
Summary: VLC opens video in a second window
Status: RESOLVED FIXED
: 955598 (view as bug list)
Alias: None
Product: openSUSE Distribution
Classification: openSUSE
Component: Other (show other bugs)
Version: Leap 42.1
Hardware: Other Other
: P5 - None : Normal with 1 vote (vote)
Target Milestone: ---
Assignee: Dominique Leuenberger
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 955598
  Show dependency treegraph
 
Reported: 2015-11-05 01:42 UTC by ilija anas
Modified: 2023-08-14 13:51 UTC (History)
15 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
vlc opens independent window in wayland (1.67 MB, image/png)
2023-07-03 07:08 UTC, Stakanov Schufter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ilija anas 2015-11-05 01:42:42 UTC
there seams to be a bug with qt 5.5 shipping with LEAP 42.1 as this is not happening with 13.1, 13.2 or Tumbleweed.
VLC opens video in a new window that can not be docked in the main app, a few threads on the forums
https://forums.opensuse.org/showthread.php/510603-VLC-Opens-2-windows?p=2735159#post2735159
https://forums.opensuse.org/showthread.php/510478-Flash-player-amp-flash-player-kde4-removed-after-zypper-dup!?p=2734134#post2734134

a screen shot speaks a thousand words
http://i.imgur.com/Dtdx3SY.jpg
this happens in both the native qt mode and in skinned mode.

sorry I chose kde application as there is no choice for qt applications
Comment 1 Stratos Zolotas 2015-11-05 09:43:09 UTC
I can confirm this issue after dist-upgrading from 13.2 to 42.1
Comment 2 Tomáš Chvátal 2015-11-05 10:18:22 UTC
Happens even on SLE12 with the Gnome.
Comment 3 Antonio Crevillén 2015-11-06 20:20:13 UTC
I can also confirm this bug


I have installed
vlc          2.2.1-291.1   Packman Repository
vlc-codecs   2.2.1-291.1   Packman Repository
vlc-noX      2.2.1-291.1   Packman Repository
vlc-qt       2.2.1-291.1   Packman Repository
vlc-noX-lang 2.2.1-291.1   Packman Repository
Comment 4 Ronnie Bailey 2015-11-07 15:44:42 UTC
The bug is not present when using VLC-beta in a fresh install of openSUSE 42.1
Comment 5 S. B. 2015-11-13 16:01:23 UTC
I can also confirm this bug on openSUSE Leap with the Cinnamon desktop and Intel graphics. I tried both the openSUSE OSS repo version and the Packman version, both properly play videos but in a separate window.

I can also confirm that vlc-beta fixes this bug (but introduces other undesirable bugs).
Comment 6 S. B. 2015-11-13 20:49:11 UTC
I can also confirm that this bug does not exist in Tumbleweed.
Comment 7 Niels Black 2015-11-16 05:17:55 UTC
I am also experiencing two windows ("integrate video in interface" option not working) with VLC from Packman Leap 42.1

Switching to a different distribution or VLC-beta fixes the two window issue, but then runs into either the QT5.5 resize/crop issue or stops working for many codecs/containers.

I'm installed in a virtualbox machine without any 3D acceleration.
Comment 8 Marcelo Borro 2015-11-20 07:05:19 UTC
Some problem here, Leap 42.1, packman packages.
Comment 9 Tomáš Chvátal 2015-11-20 07:17:11 UTC
*** Bug 955598 has been marked as a duplicate of this bug. ***
Comment 10 S. B. 2015-12-01 17:50:18 UTC
Has any thought been given to simply compiling VLC against Qt4 to fix all these issues? Most other distros don't have these major VLC issues because they still use VLC with Qt4.
Comment 11 S. B. 2015-12-04 02:55:44 UTC
Here's my Qt4 build, completely solves this issue:
http://pmbs-api.links2linux.org:8080/home:/sb56637/
Comment 12 S. B. 2015-12-05 18:54:59 UTC
I submitted the Qt4 fix for review, hopefully it will get accepted: https://build.opensuse.org/request/show/347505
Comment 13 Dominique Leuenberger 2015-12-07 04:01:07 UTC
(In reply to S. B. from comment #12)
> I submitted the Qt4 fix for review, hopefully it will get accepted:
> https://build.opensuse.org/request/show/347505

This is in the maintenance workflow now - a Qt4 based build for Leap should be made available shortly.
Comment 14 Wolfgang Bauer 2015-12-07 21:44:00 UTC
(In reply to Dominique Leuenberger from comment #13)
> (In reply to S. B. from comment #12)
> > I submitted the Qt4 fix for review, hopefully it will get accepted:
> > https://build.opensuse.org/request/show/347505
> 
> This is in the maintenance workflow now - a Qt4 based build for Leap should
> be made available shortly.

Well, this update is good and nice, but it probably won't help much as many people will install VLC from Packman or VideoLAN (which is still built against Qt5) to get the additional codecs, I suppose.

I found the actual reason for this problem though:
VLC is built without libQt5X11Extras-devel on Leap 42.1, probably because it is not available in SLE12 (it is in Leap though).
Apparently that library is needed for video integration to work.

I created packages that do BuildRequire it on Leap:
https://build.opensuse.org/package/show/home:wolfi323:branches:multimedia:libs/vlc
With those the video is integrated into the GUI now in Leap 42.1 as well.
So maybe we should rather submit this as update for Leap?

OTOH, with this fixed, we of course run into qtbug#48321 again that the video is cropped on window resize/fullscreen.
So we probably should wait with this change until an update for Qt5 in Leap is released.
Comment 15 S. B. 2015-12-08 00:06:20 UTC
(In reply to Wolfgang Bauer from comment #14)
> (In reply to Dominique Leuenberger from comment #13)
> > (In reply to S. B. from comment #12)
> > > I submitted the Qt4 fix for review, hopefully it will get accepted:
> > > https://build.opensuse.org/request/show/347505
> > 
> > This is in the maintenance workflow now - a Qt4 based build for Leap should
> > be made available shortly.
> 
> Well, this update is good and nice, but it probably won't help much as many
> people will install VLC from Packman or VideoLAN (which is still built
> against Qt5) to get the additional codecs, I suppose.
> 
> I found the actual reason for this problem though:
> VLC is built without libQt5X11Extras-devel on Leap 42.1, probably because it
> is not available in SLE12 (it is in Leap though).
> Apparently that library is needed for video integration to work.
> 
> I created packages that do BuildRequire it on Leap:
> https://build.opensuse.org/package/show/home:wolfi323:branches:multimedia:
> libs/vlc
> With those the video is integrated into the GUI now in Leap 42.1 as well.
> So maybe we should rather submit this as update for Leap?
> 
> OTOH, with this fixed, we of course run into qtbug#48321 again that the
> video is cropped on window resize/fullscreen.
> So we probably should wait with this change until an update for Qt5 in Leap
> is released.

Hmm, I guess I'm confused. I thought that Packman built as a link to the openSUSE repos.

As for Dominique's VLC/Qt5 fix, I am currently using it *from the Packman repo* (it somehow already got included there) and it completely resolves all VLC bugs I've noted thus far.
Comment 16 Wolfgang Bauer 2015-12-08 09:32:34 UTC
(In reply to S. B. from comment #15)
> Hmm, I guess I'm confused. I thought that Packman built as a link to the
> openSUSE repos.

It is.

But it links to the package in multimedia:libs (the devel repo for Factory) for all openSUSE versions, to always be up-to-date.

That's also why the other fix is in Packman already.

So, a submit to Leap doesn't change anything in Packman, you have to submit to multimedia:libs instead.
Comment 17 S. B. 2015-12-08 14:17:20 UTC
I see now, thanks for the explanation Wolfgang.

> OTOH, with this fixed, we of course run into qtbug#48321 again that the
> video is cropped on window resize/fullscreen.
> So we probably should wait with this change until an update for Qt5 in Leap
> is released.

I tried your packages, but I did run into the video scaling bug. So that's definitely good progress, and hopefully Qt5/VLC will be in good shape fairly soon. But I'd say that for now it's more important to just get a quick fix out there for users, and worry about Qt5 later. If you want I can submit a Qt4 build request to multimedia:libs?
Comment 18 Wolfgang Bauer 2015-12-08 15:45:57 UTC
(In reply to S. B. from comment #17)
> I tried your packages, but I did run into the video scaling bug. So that's
> definitely good progress, and hopefully Qt5/VLC will be in good shape fairly
> soon. 

Yes, the fix for that scaling bug has not been released yet for Leap 42.1.
I talked to Hrvoje Senjan, and he said that he will submit a Qt5 update for Leap to the current Tumbleweed packages (including the fix for that) in the next two days.

> But I'd say that for now it's more important to just get a quick fix
> out there for users, and worry about Qt5 later. If you want I can submit a
> Qt4 build request to multimedia:libs?

Personally I have to say that I'm not really fond of switching back and forth between building against Qt4 and Qt5 either...
And I don't consider this particular problem here very grave, so I'd say we should just stay with Qt5 on Leap as well, considering that all problems should be fixed now.

But well, it's not me to decide.
Comment 19 S. B. 2015-12-08 15:53:06 UTC
> I talked to Hrvoje Senjan, and he said that he will submit a Qt5 update for Leap to the current Tumbleweed packages (including the fix for that) in the next two days.

Very nice, might as well just wait then. Thanks for the update, and thanks to everyone that is working to fix these bugs.
Comment 20 Dominique Leuenberger 2015-12-08 15:53:40 UTC
If the current package in muktimedia:libs, together with the planned Qt fix is working sufficiently, i am in favor of vancelling the running submission of switching to qt4 in maintenance...

Stefan, Wolfang: you two having done most of the works and checks: what is your verdict?
Comment 21 Wolfgang Bauer 2015-12-10 17:37:06 UTC
(In reply to Dominique Leuenberger from comment #20)
> Stefan, Wolfang: you two having done most of the works and checks: what is
> your verdict?

Sorry for not replying earlier.

I see you cancelled the update already, and yes I do think that's the best, given the circumstances.

As I already wrote, all (known) problems should be fixed when the Qt5 update arrives in Leap and the current vlc (with the upstream patch you added) is indeed built against libQt5X11Extras-devel (I have yet to submit this though of course).

I'm just not completely sure yet how to proceed...

At least I/we should wait with submitting the vlc update to Leap until the Qt5 update is running I think.

But then, I don't want to submit my change to multimedia:libs before the Qt5 update is actually released, because otherwise people using Packman (and VideoLAN I suppose) will again have the resize problem.

So my suggestion, not sure if that's feasible: I will submit an update for Leap as soon as I see Qt5 in the maintenance process, but will only submit it to multimedia:libs after that Qt5 update is actually released.

Is that ok/doable?

If not, I guess I just wait and will submit to multimedia:libs first after that update.
Comment 22 S. B. 2015-12-15 21:13:10 UTC
I still think that the Qt4 build would be a perfectly good fix until the Qt5 fix is completed. I really think that something needs to be done very soon, because VLC is in really bad shape on Leap at the moment.
Comment 23 Andreas Stieger 2015-12-18 22:03:52 UTC
Please test of the proposed QT 5 update fixes the issue with a stock VLC:

http://download.opensuse.org/repositories/openSUSE:/Maintenance:/4411/openSUSE_Leap_42.1_Update/x86_64/
or
http://download.opensuse.org/update/leap/42.1-test/
Comment 24 Wolfgang Bauer 2015-12-18 22:18:10 UTC
(In reply to Andreas Stieger from comment #23)
> Please test of the proposed QT 5 update fixes the issue with a stock VLC:

No.
This issue is not caused by a bug in Qt5, but by a missing VLC build dependency, as explained in comment#14.

But I did try my updated VLC package with that Qt5 update, and all known bugs are fixed, i.e. vlc does integrate the video, and the video is correctly scaled (this was broken because of a Qt5 bug that is fixed by the update).
Comment 25 Bernhard Wiedemann 2015-12-28 15:00:08 UTC
This is an autogenerated message for OBS integration:
This bug (953693) was mentioned in
https://build.opensuse.org/request/show/351088 42.1 / vlc
Comment 26 Wolfgang Bauer 2015-12-28 15:02:49 UTC
FYI, as the Qt5 update has been released yesterday, I submitted the fix to multimedia:libs.

I requested an update for Leap 42.1 too, so this should also get fixed in the standard version included for people not installing it from elsewhere:
https://build.opensuse.org/request/show/351088
Comment 27 Andreas Stieger 2016-01-02 12:43:20 UTC
Dear reporter (or anyone else affected): Kindly install vlc from the test update repo and confirm the proposed maintenance update fixes the issue for you.

http://download.opensuse.org/update/leap/42.1-test/
Comment 28 Matthias Gensler 2016-01-02 16:35:11 UTC
Installed from ../leap/42.1-test/. Problem with 2nd window solved.
Comment 29 Andreas Stieger 2016-01-02 17:21:12 UTC
Thanks. Releasing update.
Comment 30 Swamp Workflow Management 2016-01-02 21:11:09 UTC
openSUSE-RU-2016:0003-1: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 953693
CVE References: 
Sources used:
openSUSE Leap 42.1 (src):    vlc-2.2.1-18.1
Comment 31 ilija anas 2016-01-04 11:01:08 UTC
sorry for not replaying sooner
with the latest updates from packman vlc runs great the 2 window bug has been fixed
Comment 32 Stakanov Schufter 2023-07-02 18:32:58 UTC
Regression:
Operating System: openSUSE Tumbleweed 20230629
KDE Plasma Version: 5.27.6
KDE Frameworks Version: 5.107.0
Qt Version: 5.15.10
Kernel Version: 6.3.9-1-default (64-bit)
Graphics Platform: Wayland
Processors: 12 × AMD Ryzen 5 5600G with Radeon Graphics
Memory: 62.6 GiB of RAM
Graphics Processor: AMD Radeon Pro W5500
Product Name: X570 Phantom Gaming 4

The problem reappeared with the recent update to this version. 
Prior all worked ok.
Comment 33 Stakanov Schufter 2023-07-03 07:08:14 UTC
Created attachment 867929 [details]
vlc opens independent window in wayland

this is in a Wayland session but does not happen in a X11 session. The bug is therefore valid only for Plasma Wayland.
Comment 34 Dominique Leuenberger 2023-08-14 13:51:18 UTC
(In reply to Stakanov Schufter from comment #33)
> Created attachment 867929 [details]
> vlc opens independent window in wayland
> 
> this is in a Wayland session but does not happen in a X11 session. The bug
> is therefore valid only for Plasma Wayland.

This bug was originally for Leap 42.x with VLC 2.x - tracked to a Qt change back in the days.

The same behavior does not make this the same bug. Please file a new bug with nowadays reproducer information - and information when you last saw this working so that it can hopefully be attributed to a newer change now.