Bug 426510 (CVE-2008-4109) - VUL-0: CVE-2008-4109: openssh: Signal handler bug in OpenSSH
Summary: VUL-0: CVE-2008-4109: openssh: Signal handler bug in OpenSSH
Status: RESOLVED FIXED
Alias: CVE-2008-4109
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Major
Target Milestone: ---
Deadline: 2008-10-14
Assignee: Security Team bot
QA Contact: Security Team bot
URL:
Whiteboard: CVE-2008-4109: CVSS v2 Base Score: 5....
Keywords:
Depends on: 214326
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-16 07:12 UTC by Ludwig Nussel
Modified: 2024-04-19 07:29 UTC (History)
2 users (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ludwig Nussel 2008-09-16 07:12:58 UTC
Your friendly security team received the following report via vendor-sec.
Please respond ASAP.
This issue is not widely public yet, please keep any information about it inside SUSE.

Date: Mon, 15 Sep 2008 18:44:12 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: vendor-sec@lst.de
Subject: [vendor-sec] Signal handler bug in OpenSSH
CC: openssh@openssh.com

It seems that the recent SSH scanning activity has some chance to
trigger this bug:

  <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=498678>

As a result, OpenSSH runs into the MaxStartups limit, and no further
logins are possible.

Debian will release a security update for this because it impacts our
own infrastructure.  However, the issue can also be triggered by
repeated login attempts under high system load (we saw it on a private
network without SSH scanning activity, too).  I've also received a
report about a FreeBSD machine affected in a similar way, so this is not
Linux/GNU libc specific.

If there is demand, we will delay publication of an update.  However,
the issue was discovered by looking at the source code after this has
been triggered on production servers, so it's technically already being
exploited.  A patch which is an improvement over commenting out the
do_log call would be appreciated.  (I can try to cook up something and
have it reviewed, if that helps.)  However, I understand that it is
somewhat debatable if this is a security vulnerability.
_______________________________________________
Vendor Security mailing list
Vendor Security@lst.de
https://www.lst.de/cgi-bin/mailman/listinfo/vendor-sec
Comment 3 Ludwig Nussel 2008-09-16 15:33:47 UTC
CVE-2008-4109
Comment 4 Anna Maresova 2008-09-18 12:23:28 UTC
We have never addressed this issue before. It means that we do not have a broken patch included, but we had not fixed the original issue in our older releases (sles9, sles10) yet - in fact it looks we have never backported any fix for security issues addressed in 4.4p1:

 * Fix a pre-authentication denial of service found by Tavis Ormandy,
   that would cause sshd(8) to spin until the login grace time
   expired.

 * Fix an unsafe signal hander reported by Mark Dowd. The signal
   handler was vulnerable to a race condition that could be exploited
   to perform a pre-authentication denial of service. On portable
   OpenSSH, this vulnerability could theoretically lead to
   pre-authentication remote code execution if GSSAPI authentication
   is enabled, but the likelihood of successful exploitation appears
   remote.

 * On portable OpenSSH, fix a GSSAPI authentication abort that could
   be used to determine the validity of usernames on some platforms.

Should I try to find these fixes and backport them all for sles9 and sles10?
Comment 5 Ludwig Nussel 2008-09-18 12:46:11 UTC
Your predecessor already did, see bug 208662. If not then yes, please add the missing fixes.
Comment 6 Ludwig Nussel 2008-09-19 07:30:29 UTC
setting default priority for all VUL-0 bugs
Comment 7 Anna Maresova 2008-09-22 12:14:55 UTC
Umm, you are right, sorry. I have not checked all the patches and there was no mention in the changelog about this fix. So I thought that the code comes from the source tarball.

So our newer distros are fixed, sles9/10 contain buggy patch. Although the buggy patch was included in upstream ssh for a while, no real version that contains it was released. We "backported" the fix from 4.4p1 but while 4.4p1 was OK, we took the original wrong patch - so actually I still do not understand what really happened that we released it like this.

But nevermind. I am going to prepare fixes for sles9/10 and hopefully I will get it right this time.

Comment 8 Ludwig Nussel 2008-09-22 12:23:44 UTC
ok, thanks :)
Comment 9 Anna Maresova 2008-09-22 13:40:52 UTC
Done.
In fact I could just remove everything inside sigdie() function and result would be the same for us... but I have tried to just backport the code from the upstream.
Comment 10 Marcus Meissner 2008-09-23 15:52:37 UTC
(patchinfos missing still according to Rudi)
Comment 11 Ludwig Nussel 2008-09-24 08:31:44 UTC
reusing MaintenanceTracker-19706
Comment 12 Ludwig Nussel 2008-10-01 07:18:38 UTC
updates released
Comment 13 Thomas Biege 2009-10-14 01:26:01 UTC
CVE-2008-4109: CVSS v2 Base Score: 5.0 (AV:N/AC:L/Au:N/C:N/I:N/A:P)