Bugzilla – Bug 853627
VUL-0: CVE-2013-6417: rubygem-actionpack: unsafe query generation risk (incomplete fix for CVE-2013-0155)
Last modified: 2014-05-21 08:13:58 UTC
CVE-2013-6417 is public via oss-security: Incomplete fix to CVE-2013-0155 (Unsafe Query Generation Risk) The prior fix to CVE-2013-0155 was incomplete and the use of common 3rd party libraries can accidentally circumvent the protection. This vulnerability has been assigned the CVE identifier CVE-2013-6417. Versions Affected: All. Not affected: None Fixed Versions: 4.0.2 & 3.2.16 Impact ------ Due to the way that Rack::Request and Rails::Request interact, it is possible for a 3rd party or custom rack middleware to parse the parameters insecurely and store them in the same key that Rails uses for its own parameters. In the event that happens the application will receive unsafe parameters and could be vulnerable to the earlier vulnerability. All users running an affected release should either upgrade or use one of the work arounds immediately. Releases -------- The 4.0.2 & 3.2.16 releases are available at the normal locations. Workarounds ----------- To work around this issue you need to audit your middleware chain and ensure that each of the libraries in use does not create an instance of Rack::Request. Patches ------- To aid users who aren't able to upgrade immediately we have provided patches for the two supported release series. They are in git-am format and consist of a single changeset. * 4-0-rack-params.patch - Patch for 4.0 series * 3-2-rack-params.patch - Patch for 3.2 series Please note that only the 4.0.x and 3.2.x series are supported at present. Users of earlier unsupported releases are advised to upgrade as soon as possible as we cannot guarantee the continued availability of security fixes for unsupported releases. Credits ------- Thanks to Sudhir Rao for reporting the issue to us and to James Tucker for assisting with the fix. References: http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2013-6417 https://bugzilla.redhat.com/show_bug.cgi?id=1036409
Created attachment 570189 [details] patch for 3.2.x
Created attachment 570190 [details] patch for 4.0.x
I am assigning the bug for packaging.
bugbot adjusting priority
The SWAMPID for this issue is 55366. This issue was rated as moderate. Please submit fixed packages until 2013-12-20. When done, please reassign the bug to security-team@suse.de. Patchinfo will be handled by security team.
This is an autogenerated message for OBS integration: This bug (853627) was mentioned in https://build.opensuse.org/request/show/210399 12.2 / rubygem-actionpack-3_2 https://build.opensuse.org/request/show/210404 12.3 / rubygem-actionpack-3_2 https://build.opensuse.org/request/show/210405 13.1 / rubygem-actionpack-3_2
This is an autogenerated message for OBS integration: This bug (853627) was mentioned in https://build.opensuse.org/request/show/210711 12.2 / rubygem-actionpack-3_2 https://build.opensuse.org/request/show/210713 12.3 / rubygem-actionpack-3_2 https://build.opensuse.org/request/show/210714 13.1 / rubygem-actionpack-3_2
openSUSE-SU-2013:1904-1: An update that fixes 5 vulnerabilities is now available. Category: security (moderate) Bug References: 853625,853627,853632,853633 CVE References: CVE-2013-0155,CVE-2013-4491,CVE-2013-6414,CVE-2013-6415,CVE-2013-6417 Sources used: openSUSE 12.3 (src): rubygem-actionpack-3_2-3.2.12-1.8.1
openSUSE-SU-2013:1906-1: An update that fixes 5 vulnerabilities is now available. Category: security (moderate) Bug References: 853625,853627,853632,853633 CVE References: CVE-2013-0155,CVE-2013-4491,CVE-2013-6414,CVE-2013-6415,CVE-2013-6417 Sources used: openSUSE 13.1 (src): rubygem-actionpack-3_2-3.2.13-2.4.1
openSUSE-SU-2013:1907-1: An update that fixes 5 vulnerabilities is now available. Category: security (moderate) Bug References: 853625,853627,853632,853633 CVE References: CVE-2013-0155,CVE-2013-4491,CVE-2013-6414,CVE-2013-6415,CVE-2013-6417 Sources used: openSUSE 12.2 (src): rubygem-actionpack-3_2-3.2.12-3.21.1
openSUSE-SU-2014:0009-1: An update that fixes 5 vulnerabilities is now available. Category: security (moderate) Bug References: 846239,853625,853627,853632,853633 CVE References: CVE-2013-4389,CVE-2013-4491,CVE-2013-6414,CVE-2013-6415,CVE-2013-6417 Sources used: openSUSE 13.1 (src): rubygem-actionpack-3_2-3.2.13-2.9.1 openSUSE 12.3 (src): rubygem-actionpack-3_2-3.2.12-1.13.1 openSUSE 12.2 (src): rubygem-actionpack-3_2-3.2.12-3.26.2
rubygem-actionpack-3_1 lost the function "deep_munge" in "request.rb" becuase of the patch CVE-2013-6417: --- a/actionpack/lib/action_dispatch/http/request.rb +++ b/actionpack/lib/action_dispatch/http/request.rb @@ -228,13 +228,13 @@ module ActionDispatch # Override Rack's GET method to support indifferent access def GET - @env["action_dispatch.request.query_parameters"] ||= (normalize_parameters(super) || {}) + @env["action_dispatch.request.query_parameters"] ||= deep_munge(normalize_parameters(super) || {}) end alias :query_parameters :GET # Override Rack's POST method to support indifferent access def POST - @env["action_dispatch.request.request_parameters"] ||= (normalize_parameters(super) || {}) + @env["action_dispatch.request.request_parameters"] ||= deep_munge(normalize_parameters(super) || {}) end alias :request_parameters :POST so please merge "deep_munge" into "request.rb".
Thanks Jun Wang!!
Will this be fixed and this update be rebuilt?
I've just packaged it.
Do we need reject the current workflow (55517) on swamp?
Yes Tony. I'll create a new sub workflow for the new submission.
released
Update released for: rubygem-actionpack-3_2, rubygem-actionpack-3_2-doc Products: SLE-SLMS 1.3 (x86_64) SLE-STUDIOONSITE 1.3 (x86_64) SLE-WEBYAST 1.3 (i386, ia64, ppc64, s390x, x86_64)
SUSE-SU-2014:0152-1: An update that solves four vulnerabilities and has one errata is now available. Category: security (moderate) Bug References: 846239,853625,853627,853632,853633 CVE References: CVE-2013-4491,CVE-2013-6414,CVE-2013-6415,CVE-2013-6417 Sources used: WebYaST 1.3 (src): rubygem-actionpack-3_2-3.2.12-0.11.1 SUSE Studio Onsite 1.3 (src): rubygem-actionpack-3_2-3.2.12-0.11.1 SUSE Lifecycle Management Server 1.3 (src): rubygem-actionpack-3_2-3.2.12-0.11.1
The SWAMPID for this issue is 56198. This issue was rated as moderate. Please submit fixed packages until 2014-02-25. When done, please reassign the bug to security-team@suse.de. Patchinfo will be handled by security team.
This is an autogenerated message for OBS integration: This bug (853627) was mentioned in https://build.opensuse.org/request/show/230058 Factory / rubygem-actionpack-3_2
Update released for: hawk, hawk-debuginfo, hawk-debugsource, hawk-templates Products: SLE-DEBUGINFO 11-SP3 (i386, ia64, ppc64, s390x, x86_64) SLE-HAE 11-SP3 (i386, ia64, ppc64, s390x, x86_64)
SUSE-SU-2014:0686-1: An update that solves 5 vulnerabilities and has one errata is now available. Category: security (moderate) Bug References: 846239,853625,853627,853632,853633,854060 CVE References: CVE-2013-4389,CVE-2013-4491,CVE-2013-6414,CVE-2013-6415,CVE-2013-6417 Sources used: SUSE Linux Enterprise High Availability Extension 11 SP3 (src): hawk-0.6.1-0.17.1