Bug 925225 (CVE-2014-8119) - VUL-0: CVE-2014-8119: augeas: augeas path expression injection via interface name
Summary: VUL-0: CVE-2014-8119: augeas: augeas path expression injection via interface ...
Status: RESOLVED FIXED
Alias: CVE-2014-8119
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Deadline: 2015-04-14
Assignee: Michal Filka
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/115339/
Whiteboard: maint:running:61404:low
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-31 15:35 UTC by Marcus Meissner
Modified: 2018-03-09 17:09 UTC (History)
7 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
Patch for SLE-12:Update (13.90 KB, patch)
2015-04-15 07:36 UTC, Michal Filka
Details | Diff
Patch for SLE-11-SP3:Update (27.07 KB, patch)
2015-09-09 12:11 UTC, Michal Filka
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Meissner 2015-03-31 15:35:40 UTC
rh#1172176

CVE-2014-8119

augeas-devel mailing list thread, discussing lack of ways to safely include untrusted user-supplied input in path strings used in augeas queries:

https://www.redhat.com/archives/augeas-devel/2014-December/msg00000.html
Augeas upstream issue that tracks changes required to completely fix this netcf issue:

https://github.com/hercules-team/augeas/pull/198

The changes are:

- Addition of new API - aug_escape_name() - which can be used to escape untrusted inputs before using them as part of path expressions passed to APIs as aug_match() or aug_get().

- The aug_match() is changed to return properly escaped output that can be safely passed back to aug_get().


References:
https://bugzilla.redhat.com/show_bug.cgi?id=1172176
Comment 1 Swamp Workflow Management 2015-03-31 15:45:32 UTC
An update workflow for this issue was started.
This issue was rated as moderate.
Please submit fixed packages until 2015-04-14.
When done, reassign the bug to security-team@suse.de.
https://swamp.suse.de/webswamp/wf/61404
Comment 2 Swamp Workflow Management 2015-03-31 22:00:15 UTC
bugbot adjusting priority
Comment 3 Michal Filka 2015-04-10 08:33:09 UTC
Which projects are affected by this requirement? SLE-12, SLE-11-SP<x>?

Thanks
Comment 4 Marcus Meissner 2015-04-10 08:54:28 UTC
11-sp1, 11-sp3 and 12.

SUSE:SLE-11-SP1:Update:Test                       augeas
SUSE:SLE-11-SP3:Update:Test                       augeas
SUSE:SLE-12:Update                                    augeas


and also opensuse if possble.
Comment 5 Michal Filka 2015-04-15 07:36:32 UTC
Created attachment 631085 [details]
Patch for SLE-12:Update

submission id #55394
Comment 7 Michal Filka 2015-04-15 10:26:47 UTC
Notes regarding the patch:
1) The patch introduces new function for escaping into public API
2) The patch modifies behavior of the existing API

In my POV (1) is fine, however (2) can break existing application which already performs escaping in their own.

Also we should identify applications which could benefit from using the new API - see (1).

Marcus:
Is there any common way how to handle (2) from security's point of view.
Comment 8 Lukas Ocilka 2015-04-17 09:29:05 UTC
Michal, what's the current status of backporting? Could you give us more info
about those patches?
Comment 9 Michal Filka 2015-04-17 09:39:12 UTC
(In reply to Lukas Ocilka from comment #8)
> Michal, what's the current status of backporting? Could you give us more info
> about those patches?

I have a backport (untested) for SLE-11. However, i don't release it until it is clear how to handle API inconsistency issue.
Comment 10 Marcus Meissner 2015-04-22 15:30:51 UTC
I wpould like to review the patch, can you attach it here?

I looked at the pull request and the refernces commits and that looked good so far.
Comment 11 Michal Filka 2015-04-24 07:56:03 UTC
(In reply to Marcus Meissner from comment #10)
> I wpould like to review the patch, can you attach it here?
> 
> I looked at the pull request and the refernces commits and that looked good
> so far.

in case of SLE-12 the patch is almost the same (cherry picks where almost without conflicts).

However the issue - change in API - is visible e.g. in tests provided within the patch. E.g.

-     /files/etc/php.ini/mail function/SMTP = localhost
+     /files/etc/php.ini/mail\ function/SMTP = localhost

-  /white space/[section = "value"
+  /white\ space/\[section = "value"

and others.
Comment 12 Marcus Meissner 2015-04-24 14:29:25 UTC
well.. please just submit and we can check it.

additional APIs are not a problem.

slight output changes might be fixable
Comment 13 Michal Filka 2015-05-06 07:54:50 UTC
Patch for SLE-12 submitted (https://build.suse.de/request/show/57064). I'll continue with other patches once this one is accepted.
Comment 14 Marcus Meissner 2015-05-08 15:19:44 UTC
the rq was declined:

Please resubmit as a maintenancerequest against SUSE:SLE-12:Update

also please mention the CVE nr in the .changes too.
Comment 15 Michal Filka 2015-05-11 08:47:52 UTC
resubmitted, id 57320
Comment 19 Marcus Meissner 2015-05-19 15:47:58 UTC
is in progress ...
Comment 20 Victor Pereira 2015-06-02 06:04:46 UTC
hi, are SLE-11-SP1 or SLE-11-SP3 affected as well?
Comment 23 Michal Filka 2015-06-23 07:43:08 UTC
(In reply to Victor Pereira from comment #20)
> hi, are SLE-11-SP1 or SLE-11-SP3 affected as well?

please see comment#4. Affected projects are:

> SUSE:SLE-11-SP1:Update:Test                       
> SUSE:SLE-11-SP3:Update:Test                       
> SUSE:SLE-12:Update
Comment 33 Swamp Workflow Management 2015-07-16 08:08:17 UTC
SUSE-SU-2015:1249-1: An update that fixes one vulnerability is now available.

Category: security (moderate)
Bug References: 925225
CVE References: CVE-2014-8119
Sources used:
SUSE Linux Enterprise Software Development Kit 12 (src):    augeas-1.2.0-3.1
SUSE Linux Enterprise Server 12 (src):    augeas-1.2.0-3.1
SUSE Linux Enterprise Desktop 12 (src):    augeas-1.2.0-3.1
Comment 34 Michal Filka 2015-09-09 12:11:13 UTC
Created attachment 646658 [details]
Patch for SLE-11-SP3:Update
Comment 35 Michal Filka 2015-09-10 09:13:27 UTC
Submitted maintenance request for SLE-11-SP3, id#67434
Comment 38 Swamp Workflow Management 2015-10-21 10:10:41 UTC
SUSE-SU-2015:1792-1: An update that fixes one vulnerability is now available.

Category: security (moderate)
Bug References: 925225
CVE References: CVE-2014-8119
Sources used:
SUSE Linux Enterprise Software Development Kit 11-SP4 (src):    augeas-0.9.0-3.17.2
SUSE Linux Enterprise Software Development Kit 11-SP3 (src):    augeas-0.9.0-3.17.2
SUSE Linux Enterprise Server for VMWare 11-SP3 (src):    augeas-0.9.0-3.17.2
SUSE Linux Enterprise Server 11-SP4 (src):    augeas-0.9.0-3.17.2
SUSE Linux Enterprise Server 11-SP3 (src):    augeas-0.9.0-3.17.2
SUSE Linux Enterprise Desktop 11-SP4 (src):    augeas-0.9.0-3.17.2
SUSE Linux Enterprise Desktop 11-SP3 (src):    augeas-0.9.0-3.17.2
SUSE Linux Enterprise Debuginfo 11-SP4 (src):    augeas-0.9.0-3.17.2
SUSE Linux Enterprise Debuginfo 11-SP3 (src):    augeas-0.9.0-3.17.2
Comment 39 Michal Filka 2015-11-03 09:50:13 UTC
Submitted maintenance request for SLE-11-SP1, id#77487
Comment 40 Michal Filka 2015-12-01 07:30:09 UTC
SLE-12*, SLE-11-SP{1,3}, OpenSUSE:{Leap,Tumbleweed} should be fixed (patch provided or fixed by most recent upstream version). So, closing.
Comment 41 Bernhard Wiedemann 2017-05-30 10:02:08 UTC
This is an autogenerated message for OBS integration:
This bug (925225) was mentioned in
https://build.opensuse.org/request/show/499623 Factory / augeas
Comment 42 Bernhard Wiedemann 2017-06-02 10:03:34 UTC
This is an autogenerated message for OBS integration:
This bug (925225) was mentioned in
https://build.opensuse.org/request/show/500542 Factory / augeas
Comment 44 Swamp Workflow Management 2018-03-09 17:09:38 UTC
SUSE-SU-2018:0653-1: An update that fixes two vulnerabilities is now available.

Category: security (moderate)
Bug References: 1054171,925225
CVE References: CVE-2014-8119,CVE-2017-7555
Sources used:
SUSE Linux Enterprise Software Development Kit 11-SP4 (src):    augeas-0.9.0-3.21.3.1
SUSE Linux Enterprise Server 11-SP4 (src):    augeas-0.9.0-3.21.3.1
SUSE Linux Enterprise Debuginfo 11-SP4 (src):    augeas-0.9.0-3.21.3.1