Bugzilla – Bug 986827
VUL-0: CVE-2016-5728: kernel-source: Race condition in the vop_ioctl function in drivers/misc/mic/vop/vop_vringh.c in the MIC VOP driver ...
Last modified: 2017-03-02 10:12:15 UTC
CVE-2016-5728 commit 9bf292bfca94694a721449e3fd752493856710f6 Author: Ashutosh Dixit <ashutosh.dixit@intel.com> Date: Wed Apr 27 14:36:05 2016 -0700 misc: mic: Fix for double fetch security bug in VOP driver The MIC VOP driver does two successive reads from user space to read a variable length data structure. Kernel memory corruption can result if the data structure changes between the two reads. This patch disallows the chance of this happening. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116651 Reported by: Pengfei Wang <wpengfeinudt@gmail.com> Reviewed-by: Sudeep Dutt <sudeep.dutt@intel.com> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> diff --git a/drivers/misc/mic/vop/vop_vringh.c b/drivers/misc/mic/vop/vop_vringh.c index e94c7fb..88e4523 100644 --- a/drivers/misc/mic/vop/vop_vringh.c +++ b/drivers/misc/mic/vop/vop_vringh.c @@ -945,6 +945,11 @@ static long vop_ioctl(struct file *f, unsigned int cmd, unsigned long arg) ret = -EFAULT; goto free_ret; } + /* Ensure desc has not changed between the two reads */ + if (memcmp(&dd, dd_config, sizeof(dd))) { + ret = -EINVAL; + goto free_ret; + } mutex_lock(&vdev->vdev_mutex); mutex_lock(&vi->vop_mutex); ret = vop_virtio_add_device(vdev, dd_config); References: http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2016-5728 http://www.cvedetails.com/cve/CVE-2016-5728/
The code seems to have been added in Linux 4.5
(In reply to Marcus Meissner from comment #1) > The code seems to have been added in Linux 4.5 Right, and it's already fixed on TW, as it's included in 4.6.1.
bugbot adjusting priority
So, there is no need for extra action. Reassigned back to security team.
done