Bug 988935 (CVE-2016-6519) - VUL-0: CVE-2016-6519: openstack-manila: Persistent XSS in Metadata field
Summary: VUL-0: CVE-2016-6519: openstack-manila: Persistent XSS in Metadata field
Status: RESOLVED FIXED
Alias: CVE-2016-6519
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Major
Target Milestone: ---
Assignee: Cloud Bugs
QA Contact: Security Team bot
URL: https://bugs.launchpad.net/manila-ui/...
Whiteboard: CVSSv2:SUSE:CVE-2016-6519:6.0:(AV:N/A...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-14 10:44 UTC by Andreas Stieger
Modified: 2017-10-13 14:04 UTC (History)
5 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
fix provided upstream (7.95 KB, text/plain)
2016-07-14 11:51 UTC, Thomas Bechtold
Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 2 Thomas Bechtold 2016-07-14 11:51:42 UTC
Created attachment 684261 [details]
fix provided upstream
Comment 4 Swamp Workflow Management 2016-07-14 22:00:13 UTC
bugbot adjusting priority
Comment 7 Andreas Stieger 2016-08-03 08:12:38 UTC
CVE-2016-6519 was assigned by MITRE.
Comment 10 Thomas Bechtold 2016-08-15 10:13:37 UTC
Submission is: https://build.suse.de/request/show/119584
Comment 11 Andreas Stieger 2016-08-15 11:32:36 UTC
Draft advisory, asking upstream if that is okay...

CRD: to be determined...
CVE-2016-6519: OpenStack manila-ui: Persistent XSS in Metadata field

It was discovered that the Metadata field in the "Create Share" form allows users to inject malicious HTML/JavaScript code that will be reflected in the "Shares" overview. The issue comes from a mark_safe() call on the user supplied metadata.

https://github.com/openstack/manila-ui/blob/d5fe23e4ba30846acdd09fa1dc61a415016a7e26/manila_ui/dashboards/project/shares/shares/tabs.py#L49

Remote, authenticated, but unprivileged users could exploit this vulnerability to escalate privileges by stealing session cookies.

Due to the size limitation of metadata strings the malicious payload needs to be split over multiple keys. In order to reproduce this issue, in Horizon, go to Project -> Compute -> Shares -> Create Share. In the Metadata field, add the following payload:

a=<script>alert("test")/*
b=*/<script>

As soon as the share is created, the payload is reflected in the browser. It will also be reflected each time the Shares list will be loaded (e.g. by clicking on Project -> Compute -> Shares).

The issue was discovered by Niklaus Schiess, the fix was provided Valeriy Ponomaryov.

MITRE assigned CVE-2016-6519 to this issue.
The upstream bug is https://bugs.launchpad.net/manila-ui/+bug/1597738
The SUSE bug is https://bugzilla.suse.com/show_bug.cgi?id=988935
SUSE's evaluation has a CVSS base score 6.0 (AV:N/AC:M/Au:S/C:P/I:P/A:P)
Comment 12 Thomas Bechtold 2016-08-29 08:21:48 UTC
ping - any updates here? Any release date available?
Comment 13 Marcus Meissner 2016-08-29 09:19:12 UTC
did you get any emails? andreas is on vacation still, we did not get any on the security lists at least.
Comment 14 Thomas Bechtold 2016-08-29 09:41:22 UTC
(In reply to Marcus Meissner from comment #13)
> did you get any emails? andreas is on vacation still, we did not get any on
> the security lists at least.

No. I pinged the upstream PTL now in the launchpad bug and on irc...
Comment 15 Thomas Bechtold 2016-08-29 12:58:09 UTC
Confirmed release date is now 2016-09-07 12:00 UTC (see https://bugs.launchpad.net/manila-ui/+bug/1597738 ).

@meissner : Is that enough to continue with that? Or do you need anything else from upstream?
Comment 16 Marcus Meissner 2016-08-30 10:56:54 UTC
I think thats it. I set the CRD in the update we have queued.
Comment 17 Marcus Meissner 2016-08-30 11:15:25 UTC
CRD: 2017-09-07 12:00 UTC
Comment 18 Marcus Meissner 2016-08-31 12:59:57 UTC
CRD: 2016-09-07 12:00 UTC
Comment 19 Thomas Bechtold 2016-09-07 16:30:28 UTC
- Have we released the update for Cloud6 today?
- Is the bug now public?
Comment 24 Marcus Meissner 2016-09-15 12:43:16 UTC
made public.
Comment 25 alex runge 2016-09-21 11:43:10 UTC
(In reply to Marcus Meissner from comment #24)
> made public.

I'm struggling to find a manila update in the SC6 repos... has anything been released, yet?
Also https://bugs.launchpad.net/manila-ui/+bug/1597738 is not yet accessible publicly.

alex
Comment 26 Marcus Meissner 2016-09-21 11:53:34 UTC
Ouw own update is still in QA with our QA team.

I emailed the author too who is in control of the launchpad bug.
Comment 29 Andreas Stieger 2016-10-05 07:34:06 UTC
Releasing update.
Comment 30 Swamp Workflow Management 2016-10-05 11:09:21 UTC
SUSE-SU-2016:2457-1: An update that fixes one vulnerability is now available.

Category: security (moderate)
Bug References: 988935
CVE References: CVE-2016-6519
Sources used:
SUSE OpenStack Cloud 6 (src):    openstack-horizon-plugin-manila-ui-1.2.1~a0~dev2-3.1