Bug 1194796 (CVE-2021-23567) - VUL-1: CVE-2021-23567: nodejs6,nodejs14,nodejs4,nodejs8,nodejs10,nodejs12: DoS due to infinite loop in the americanFlag module
Summary: VUL-1: CVE-2021-23567: nodejs6,nodejs14,nodejs4,nodejs8,nodejs10,nodejs12: Do...
Status: RESOLVED INVALID
Alias: CVE-2021-23567
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P5 - None : Minor
Target Milestone: ---
Assignee: Adam Majer
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/320565/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-17 16:42 UTC by Thomas Leroy
Modified: 2022-01-17 16:52 UTC (History)
1 user (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Leroy 2022-01-17 16:42:22 UTC
CVE-2021-23567

The package colors after 1.4.0 are vulnerable to Denial of Service (DoS) that
was introduced through an infinite loop in the americanFlag module.
Unfortunately this appears to have been a purposeful attempt by a maintainer of
colors to make the package unusable, other maintainers' controls over this
package appear to have been revoked in an attempt to prevent them from fixing
the issue. Vulnerable Code js for (let i = 666; i < Infinity; i++;) {
Alternative Remediation Suggested * Pin dependancy to 1.4.0

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2021-23567
https://github.com/Marak/colors.js/issues/285
https://github.com/Marak/colors.js/issues/285%23issuecomment-1008212640
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-23567
https://github.com/Marak/colors.js/commit/074a0f8ed0c31c35d13d28632bd8a049ff136fb6%23diff-92bbac9a308cd5fcf9db165841f2d90ce981baddcb2b1e26cfff170929af3bd1R18
https://snyk.io/vuln/SNYK-JS-COLORS-2331906
https://snyk.io/blog/open-source-maintainer-pulls-the-plug-on-npm-packages-colors-and-faker-now-what/
Comment 1 Thomas Leroy 2022-01-17 16:48:27 UTC
This weird component was introduced in this recent commit [0], present in versions after 1.4.0 (not included). I think none of the nodejs versions that we ship contains a more recent versions of the colors npm. I think this is also true for openSUSE codestreams. 

[0] https://github.com/Marak/colors.js/commit/074a0f8ed0c31c35d13d28632bd8a049ff136fb6
Comment 3 Thomas Leroy 2022-01-17 16:52:59 UTC
Thanks Adam for the confirmation. I close the issue.