Bug 1183371 (CVE-2021-24031) - VUL-0: CVE-2021-24031: zstd: adds read permissions to files while being compressed or uncompressed
Summary: VUL-0: CVE-2021-24031: zstd: adds read permissions to files while being compr...
Status: RESOLVED FIXED
Alias: CVE-2021-24031
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Ali Abdallah
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/279114/
Whiteboard: CVSSv3.1:SUSE:CVE-2021-24031:6.2:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-11 10:55 UTC by Robert Frohl
Modified: 2021-08-06 12:36 UTC (History)
1 user (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 2 Robert Frohl 2021-03-11 11:33:14 UTC
(In reply to Robert Frohl from comment #1)
> fixes:
> https://github.com/facebook/zstd/pull/1644/files

My take is that this patch gets superseded by the fix for CVE-2021-24032/bsc#1183370

> and maybe:
> https://github.com/facebook/zstd/pull/2525/files

Looks like a good hardening, maybe we can take this one too.
Comment 3 Robert Frohl 2021-03-11 11:33:47 UTC
tracking as affected:

SUSE:SLE-15:Update/zstd
Comment 4 Ali Abdallah 2021-03-11 11:54:10 UTC
(In reply to Robert Frohl from comment #2)
> (In reply to Robert Frohl from comment #1)
> > fixes:
> > https://github.com/facebook/zstd/pull/1644/files
> 
> My take is that this patch gets superseded by the fix for
> CVE-2021-24032/bsc#1183370

Yep

> > and maybe:
> > https://github.com/facebook/zstd/pull/2525/files
> 
> Looks like a good hardening, maybe we can take this one too.

Yes it looks good to me, but It is not yet merged upstream.
Comment 5 Ali Abdallah 2021-03-11 15:52:08 UTC
(In reply to Robert Frohl from comment #1)
> fixes:
> https://github.com/facebook/zstd/pull/1644/files

We already have the two commits of PR 1644 that presumably fix CVE-2021-24031. We are only affected by CVE-2021-24032, which says basically that fixes for CVE-2021-24031 are not enough and one can still exploit a race to access world-readable destination file.

I suggest to close this bug and continue on bug 1183370 to backport PR:2495 [1].

Concerning PR:2525 [2], it supersedes PR:2495 and provides a better hardening, but it is not yet reviewed and merged, and it is less trivial to backport. I would leave it and take PR:2495 that fixes both CVE-2021-24031 and CVE-2021-24032 for he moment.

[1] https://github.com/facebook/zstd/pull/2495/files
[2] https://github.com/facebook/zstd/pull/2525/files
Comment 8 Swamp Workflow Management 2021-03-24 17:17:00 UTC
SUSE-SU-2021:0948-1: An update that fixes two vulnerabilities is now available.

Category: security (moderate)
Bug References: 1183370,1183371
CVE References: CVE-2021-24031,CVE-2021-24032
JIRA References: 
Sources used:
SUSE MicroOS 5.0 (src):    zstd-1.4.4-1.6.1
SUSE Linux Enterprise Module for Basesystem 15-SP2 (src):    zstd-1.4.4-1.6.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 9 Swamp Workflow Management 2021-03-27 23:17:59 UTC
openSUSE-SU-2021:0481-1: An update that fixes two vulnerabilities is now available.

Category: security (moderate)
Bug References: 1183370,1183371
CVE References: CVE-2021-24031,CVE-2021-24032
JIRA References: 
Sources used:
openSUSE Leap 15.2 (src):    zstd-1.4.4-lp152.2.3.1