Bug 1186190 (CVE-2021-32618) - VUL-0: CVE-2021-32618: python-Flask-Security,python-Flask-Security-Too: redirects after many successful views by honoring the ?next query param
Summary: VUL-0: CVE-2021-32618: python-Flask-Security,python-Flask-Security-Too: redir...
Status: RESOLVED FIXED
Alias: CVE-2021-32618
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Minor
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/284534/
Whiteboard: CVSSv3.1:SUSE:CVE-2021-32618:5.4:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-18 09:44 UTC by Robert Frohl
Modified: 2024-05-16 14:15 UTC (History)
5 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Frohl 2021-05-18 09:44:05 UTC
CVE-2021-32618

The Python "Flask-Security-Too" package is used for adding security features to
your Flask application. It is an is an independently maintained version of
Flask-Security based on the 3.0.0 version of Flask-Security. All versions of
Flask-Security-Too allow redirects after many successful views (e.g. /login) by
honoring the ?next query param. There is code in FS to validate that the url
specified in the next parameter is either relative OR has the same netloc
(network location) as the requesting URL. This check utilizes Pythons urlsplit
library. However many browsers are very lenient on the kind of URL they accept
and 'fill in the blanks' when presented with a possibly incomplete URL. As a
concrete example - setting http://login?next=\\\github.com will pass FS's
relative URL check however many browsers will gladly convert this to
http://github.com. Thus an attacker could send such a link to an unwitting user,
using a legitimate site and have it redirect to whatever site they want. This is
considered a low severity due to the fact that if Werkzeug is used (which is
very common with Flask applications) as the WSGI layer, it by default ALWAYS
ensures that the Location header is absolute - thus making this attack vector
mute. It is possible for application writers to modify this default behavior by
setting the 'autocorrect_location_header=False`.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2021-32618
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-32618
https://github.com/Flask-Middleware/flask-security/issues/486
https://github.com/Flask-Middleware/flask-security/security/advisories/GHSA-6qmf-fj6m-686c
Comment 1 Robert Frohl 2021-05-18 09:46:21 UTC
tracking as affected:
- SUSE:SLE-15-SP2:Update/python-Flask-Security-Too

needed in Factory too.
Comment 2 Gianluca Gabrielli 2022-08-03 12:17:08 UTC
I think CVE-2021-23385 (bsc#1202105,1) could be a duplicated of CVE-2021-32618.
Comment 3 Gianluca Gabrielli 2022-08-03 12:39:08 UTC
Here [0] is the upstream patch.

Affected packages:
 - SUSE:SLE-15-SP1:Update/python-Flask-Security     3.0.0
 - SUSE:SLE-15-SP2:Update/python-Flask-Security-Too 3.4.2

Already fixed:
 - openSUSE:Factory/python-Flask-Security-Too       4.1.3


[0] https://github.com/Flask-Middleware/flask-security/commit/e39bb04615050448c1b8ba4caa7dacc0edd3e405
Comment 4 Thomas Leroy 2022-09-14 09:33:49 UTC
(In reply to Gianluca Gabrielli from comment #3)
> Here [0] is the upstream patch.
> 
> Affected packages:
>  - SUSE:SLE-15-SP1:Update/python-Flask-Security     3.0.0
>  - SUSE:SLE-15-SP2:Update/python-Flask-Security-Too 3.4.2
> 
> Already fixed:
>  - openSUSE:Factory/python-Flask-Security-Too       4.1.3
> 
> 
> [0]
> https://github.com/Flask-Middleware/flask-security/commit/
> e39bb04615050448c1b8ba4caa7dacc0edd3e405

Could you please take a look Matej? :)
Comment 5 Matej Cepl 2022-09-21 22:32:05 UTC
https://github.com/Flask-Middleware/flask-security/issues/486 suggests that this is a duplicate of bug CVE-2021-23385.
Comment 7 Matej Cepl 2022-09-22 08:07:12 UTC
Err, that is actually the bug 1202105.