Bug 314328 (MONO56621) - [PATCH] MS AssemblyBuilder doesn't build delay-signed assemblies
Summary: [PATCH] MS AssemblyBuilder doesn't build delay-signed assemblies
Status: RESOLVED FIXED
Alias: MONO56621
Product: Mono: Compilers
Classification: Mono
Component: C# (show other bugs)
Version: unspecified
Hardware: Other All
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Mono Bugs
QA Contact: Mono Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-07 17:17 UTC by Sebastien Pouliot
Modified: 2007-09-15 21:24 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
bug56621.tar.gz (1.23 KB, application/octet-stream)
2004-04-07 17:18 UTC, Thomas Wiest
Details
proposed patch (2.62 KB, patch)
2004-08-13 17:15 UTC, Thomas Wiest
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiest 2007-09-15 18:33:11 UTC


---- Reported by sebastien@ximian.com 2004-04-07 10:17:37 MST ----

Description of Problem:
Microsoft version of AssemblyBuilder doesn't seems to like building
delay-signed assemblies.


Steps to reproduce the problem:
1. Compile the six attached files (.tar.gz)
2. Compare the results between CSC, MCS (mono), MCS (ms)


Actual Results:
Results with MCS on Microsoft runtime

sn1.cs   SUCCESS
sn2.cs   CS1548 - with an explaination about delay-signing
sn3.cs   CS1548 - normal
sn4.cs   CS1548 - with an explaination about delay-signing
sn5.cs   CS1606 - normal
sn6.cs   CS1548 - with an explaination about delay-signing


Expected Results:
This is the results with 
- CSC, and
- MCS on Mono's runtime.

sn1.cs   SUCCESS
sn2.cs   SUCCESS
sn3.cs   CS1548
sn4.cs   SUCCESS
sn5.cs   CS1606
sn6.cs   SUCCESS


How often does this happen? 
Always


Additional Information:
- Patch new_codegen.diff from https://bugzilla.novell.com/show_bug.cgi?id=MONO56564 must be applied to get the same
results.
- While this affects MCS it's possible the fix will be limited to changes
in the class library.



---- Additional Comments From sebastien@ximian.com 2004-04-07 10:18:12 MST ----

Created an attachment
https://bugzilla.novell.com/show_bug.cgi?id=MONO56621.tar.gz




---- Additional Comments From miguel@ximian.com 2004-04-22 00:57:39 MST ----

Sebastien, is it a good fix to just warn the user that it is not
possible to delay-sign an assembly on Windows with the Microsoft
runtime?




---- Additional Comments From sebastien@ximian.com 2004-04-22 07:34:01 MST ----

Miguel, I would think so. At least this is the current bahaviour with
the (applied) patch,
http://bugzilla.ximian.com/showattachment.cgi?attach_id=7230,
from #56464.

I opened this bug so we don't loose track of the problem - as there is
probably an (undocumented) way to produce delay-signed assemblies.
Maybe it's resolution should be change to "INCOMPLETE" ?



---- Additional Comments From sebastien@ximian.com 2004-08-13 10:15:06 MST ----

Created an attachment (id=165863)
proposed patch




---- Additional Comments From sebastien@ximian.com 2004-08-13 10:18:49 MST ----

This patch fix the delay-signed problem under the MS runtime. However
it doesn't work with the Mono runtime (i.e. we behave differently in
the class library).

The fixes to the class library shouldn't change the MCS patch (as it
works under MS runtime) so it can be reviewed separately.

I'll update this bug report when the fixes are commited to CVS.



---- Additional Comments From sebastien@ximian.com 2004-08-13 10:45:30 MST ----

System.Reflection.Emit.AssemblyBuilder has been fixed and commited (to
both MONO_1_0 and HEAD).

However as we are changing how we delay-sign assemblies there is a
slight risk of breaking the contributor's build IF mcs is updated
before corlib (but not if corlib is updated before mcs).



---- Additional Comments From sebastien@ximian.com 2004-09-07 11:40:13 MST ----

Better publicity ;-)



---- Additional Comments From miguel@ximian.com 2004-09-19 02:54:03 MST ----

This is a month old, when should we close this?



---- Additional Comments From sebastien@ximian.com 2004-09-19 22:03:11 MST ----

Commited to CVS.


Imported an attachment (id=165862)
Imported an attachment (id=165863)