Bug 315461 (MONO61441) - [PATCH] avoid callvirt with ctors
Summary: [PATCH] avoid callvirt with ctors
Status: RESOLVED FIXED
Alias: MONO61441
Product: Mono: Runtime
Classification: Mono
Component: misc (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Mono Bugs
QA Contact: Mono Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-12 20:42 UTC by Ben Maurer
Modified: 2007-09-15 21:24 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
mini-ctor-no-callvirt.patch (729 bytes, patch)
2004-07-12 20:42 UTC, Thomas Wiest
Details | Diff
Fix issue that zoltan found (2.05 KB, patch)
2004-08-30 23:50 UTC, Thomas Wiest
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiest 2007-09-15 18:46:36 UTC


---- Reported by bmaurer@users.sf.net 2004-07-12 13:42:17 MST ----

We call constructors with the callvirt convention. So, a ctor becomes

<allocate>
<push args>
callvirt .ctor

By using `call' we avoid the nullcheck which reduces code size.

what is returned from the allocator will never be null -- if we are out of
memory we throw an exception.



---- Additional Comments From bmaurer@users.sf.net 2004-07-12 13:42:33 MST ----

Created an attachment (id=166442)
mini-ctor-no-callvirt.patch




---- Additional Comments From vargaz@freemail.hu 2004-08-14 12:33:43 MST ----

This patch causes tests/context-static.exe to fail, possibly because
avoiding a virtual call also causes us to avoid all the stuff in
mini_emit_virtual_call, like the calling of the remoting invoke
wrappers.



---- Additional Comments From bmaurer@users.sf.net 2004-08-30 16:50:01 MST ----

Created an attachment (id=166443)
Fix issue that zoltan found




---- Additional Comments From vargaz@gmail.com 2005-03-27 17:28:32 MST ----

I think this is ok to check in. Sorry I missed the modified patch.



---- Additional Comments From vargaz@gmail.com 2005-03-29 17:32:13 MST ----

Patch checked in.

Imported an attachment (id=166442)
Imported an attachment (id=166443)

Unknown operating system unknown. Setting to default OS "Other".