Bug 315468 (MONO61479) - [PATCH] Make OP_MEMCPY and OP_MEMSET take a base
Summary: [PATCH] Make OP_MEMCPY and OP_MEMSET take a base
Status: RESOLVED FIXED
Alias: MONO61479
Product: Mono: Runtime
Classification: Mono
Component: misc (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Enhancement
Target Milestone: ---
Assignee: Mono Bugs
QA Contact: Mono Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-13 18:45 UTC by Ben Maurer
Modified: 2007-09-15 21:24 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
mini-memcpy-base-base.patch (1.03 KB, patch)
2004-07-13 18:45 UTC, Thomas Wiest
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiest 2007-09-15 18:46:41 UTC


---- Reported by bmaurer@users.sf.net 2004-07-13 11:45:37 MST ----

Before, we would emit constructs like:

  3c:	8b 45 08             	mov    eax,DWORD PTR [ebp+8]
  3f:	8d 4d ec             	lea    ecx,[ebp-20]
  42:	8b 11                	mov    edx,DWORD PTR [ecx]
  44:	89 10                	mov    DWORD PTR [eax],edx
  46:	8b 51 04             	mov    edx,DWORD PTR [ecx+4]
  49:	89 50 04             	mov    DWORD PTR [eax+4],edx
  4c:	8b 51 08             	mov    edx,DWORD PTR [ecx+8]
  4f:	89 50 08             	mov    DWORD PTR [eax+8],edx
  52:	8b 49 0c             	mov    ecx,DWORD PTR [ecx+12]
  55:	89 48 0c             	mov    DWORD PTR [eax+12],ecx

for a memcpy. Rather than using the lea, patch makes us use [ebp-20] then
[ebp-16] and so on. This allows us to avoid using the lea instruction.



---- Additional Comments From bmaurer@users.sf.net 2004-07-13 11:45:54 MST ----

Created an attachment (id=166449)
mini-memcpy-base-base.patch




---- Additional Comments From lupus@ximian.com 2004-07-29 10:27:58 MST ----

Plase commit with the proper changelog entry.



---- Additional Comments From bmaurer@users.sf.net 2004-07-29 14:18:39 MST ----

done

Imported an attachment (id=166449)

Unknown operating system unknown. Setting to default OS "Other".