Bug 315919 (MONO64675) - [PATCH] Avoid long encodings for push operations
Summary: [PATCH] Avoid long encodings for push operations
Status: RESOLVED FIXED
Alias: MONO64675
Product: Mono: Runtime
Classification: Mono
Component: misc (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Enhancement
Target Milestone: ---
Assignee: Mono Bugs
QA Contact: Mono Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-30 22:26 UTC by Ben Maurer
Modified: 2007-09-15 21:24 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
patch (3.66 KB, patch)
2004-08-30 22:26 UTC, Thomas Wiest 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiest 2007-09-15 18:52:26 UTC 


---- Reported by bmaurer@users.sf.net 2004-08-30 15:26:09 MST ----

push imm can be used with an imm8. This saves 3 bytes of code space. By
enabling this, overall code size was reduced by over one percent.



---- Additional Comments From bmaurer@users.sf.net 2004-08-30 15:26:28 MST ----

Created an attachment (id=166710)
patch




---- Additional Comments From vargaz@freemail.hu 2004-08-31 08:40:18 MST ----

I would rename push_imm_long to push_imm_template to follow the naming
convention used on other platforms, and define it as:

#define x86_push_imm_template(inst) x86_push_imm ((inst), 0xf0f0f0)

Other than this, this is ok to check in.



---- Additional Comments From bmaurer@users.sf.net 2004-08-31 22:33:55 MST ----

in cvs

Imported an attachment (id=166710)

Unknown operating system unknown. Setting to default OS "Other".