Bug 316181 (MONO67625) - TypeManager.CSharpName does not check its input for null
Summary: TypeManager.CSharpName does not check its input for null
Status: RESOLVED FIXED
Alias: MONO67625
Product: Mono: Compilers
Classification: Mono
Component: C# (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Mono Bugs
QA Contact: Mono Bugs
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2004-10-05 22:27 UTC by John Luke
Modified: 2007-09-15 21:24 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
proposed fix (1.05 KB, patch)
2004-10-05 22:30 UTC, Thomas Wiest
Details | Diff
patch2 (2.42 KB, patch)
2004-10-07 22:46 UTC, Thomas Wiest
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiest 2007-09-15 18:55:33 UTC


---- Reported by jluke@cfl.rr.com 2004-10-05 15:27:25 MST ----

If null is passed in to it, it causes a NullReferenceException.  This seems
to cause both cs0715.cs and cs0558.cs to fail.  Attaching a patch to check
for null that fixes these two tests.



---- Additional Comments From jluke@cfl.rr.com 2004-10-05 15:30:52 MST ----

Created an attachment (id=166881)
proposed fix




---- Additional Comments From miguel@ximian.com 2004-10-07 13:40:43 MST ----

None of those tests are on CVS, could you add them please?

In general, the error is passing null in the first place, so I would
lean towards correcting the bug itself, and not the manifestation of
the bug.



---- Additional Comments From jluke@cfl.rr.com 2004-10-07 14:30:56 MST ----

The tests are in mcs/errors/. in cvs already aren't they?  If not I
wonder how I got them.

I thought it would be easier to catch all the errors in one spot, but
I can do it that way also. All 3 cases (shaver's xpcom-dotnet was the
first) I currently know of come from the same path.



---- Additional Comments From jluke@cfl.rr.com 2004-10-07 15:46:12 MST ----

Created an attachment (id=166882)
patch2




---- Additional Comments From marek.safar@seznam.cz 2004-10-17 14:32:14 MST ----

In CVS

Imported an attachment (id=166881)
Imported an attachment (id=166882)

Unknown operating system unknown. Setting to default OS "Other".