---- Reported by radical@gmail.com 2005-04-08 12:18:12 MST ----

monodis outputs:

newobj instance void class [mscorlib]System.'Int32[,]'::.ctor(int32, int32)

The Int32[,] is quoted.. ilasm's parser does not understand such a quoted
array.

Patch to monodis to NOT quote it.. 

After the patch:

newobj instance void class [mscorlib]System.Int32[,]::.ctor(int32, int32)



---- Additional Comments From radical@gmail.com 2005-04-08 12:23:00 MST ----

Created an attachment (id=167716)
Patch file..




---- Additional Comments From miguel@ximian.com 2005-04-09 15:20:10 MST ----

Jackson, can you comment if this is a limitation in our assembler, or
if this is a bug in Monodis?



---- Additional Comments From radical@gmail.com 2005-04-11 00:48:28 MST ----

A bug in our assembler.. 



---- Additional Comments From radical@gmail.com 2005-04-11 01:52:46 MST ----

Umm..correction.. not a bug in our assembler.

ildasm.exe by default seems to quote only things like

valuetype '<PrivateImplementationDetails>'/$ArrayType$0

Our assembler can handle this AND with all names quoted

ildasm.exe /quoteallnames

Monodis should follow one of the above approaches by default and maybe
have the other available as an option.
So, the patch improves the conformance to the first approach.



---- Additional Comments From miguel@ximian.com 2005-04-16 12:32:10 MST ----

Thanks.  This patch can be applied.



---- Additional Comments From rharinath@novell.com 2005-04-18 15:55:34 MST ----

Ankit and I discussed it, and deduced that it probably is a monodis
bug.  The quoting of Foo[,] should be

  'Foo'[,]

not

  'Foo[,]'

From what I could make out, the latter is an identifier named
'Foo[,]', quoted to prevent the special meaning of '['.

The original patch is incomplete, and I think we should instead fix
'get_escaped_name' to recurse down the ElementType before printing the
escaped name.



---- Additional Comments From radical@gmail.com 2005-04-19 07:55:49 MST ----

Created an attachment (id=167717)
monodis-sqstring.patch




---- Additional Comments From radical@gmail.com 2005-04-19 07:56:57 MST ----

Patch attached above is for the problem hari described.



---- Additional Comments From radical@gmail.com 2005-04-20 11:17:19 MST ----

Created an attachment (id=167718)
updated patch (redone)




---- Additional Comments From radical@gmail.com 2005-04-20 12:25:19 MST ----

Fixed in SVN.

Imported an attachment (id=167716)
Imported an attachment (id=167717)
Imported an attachment (id=167718)

Unknown operating system unknown. Setting to default OS "Other".