Bugzilla – Bug 317697
[PATCH] MonoTests.System.Reflection.Emit.MethodBuilderTest.TestDynamicParam
Last modified: 2007-09-15 21:24:46 UTC
---- Reported by radical@gmail.com 2005-04-14 13:24:29 MST ---- Patch for fixing the failing test case. Basically, in case of SRE the types of default values are ignored, so the patch adds a "guint32* param_default_types" to MethodReflectionMethodAux.. and sets it accordingly. ---- Additional Comments From radical@gmail.com 2005-04-14 13:24:54 MST ---- Created an attachment (id=167745) defval.patch ---- Additional Comments From radical@gmail.com 2005-04-15 08:36:35 MST ---- The line 'm->signature->params [i -1]->attrs = pb->attrs' in reflection_methodbuilder_to_mono_method, assumes that the following invariant holds: params [i - 1] does not point to the 'byval_arg' of any MonoClass. This is true for signatures of reflected methods. It is not true for dynamic methods. So, the second part of the patch ensures this invariant in parameters_to_signature. It is better to ensure the invariant in parameters_to_signature, since we don't want to needlessly allocate another MonoType* in reflection_methodbuilder_to_mono_method. (Fixed by Hari) ---- Additional Comments From radical@gmail.com 2005-04-15 08:38:00 MST ---- Created an attachment (id=167746) refl.patch ---- Additional Comments From radical@gmail.com 2005-04-15 08:42:56 MST ---- Created an attachment (id=167747) Patch.. updated. (removed an extra g_malloc) ---- Additional Comments From vargaz@gmail.com 2005-04-16 13:47:54 MST ---- Fixed in SVN. Thanks for the patch. Imported an attachment (id=167745) Imported an attachment (id=167746) Imported an attachment (id=167747) Unknown operating system unknown. Setting to default OS "Other".