Bug 320711 (MONO77961) - [PATH] Add overloads to Report.Warning/Error methods to reduce code size
Summary: [PATH] Add overloads to Report.Warning/Error methods to reduce code size
Status: RESOLVED FIXED
Alias: MONO77961
Product: Mono: Compilers
Classification: Mono
Component: C# (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Raja R Harinath
QA Contact: Mono Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-30 15:14 UTC by Forgotten User vxPDddArjq
Modified: 2007-09-15 21:24 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
patch (3.15 KB, patch)
2006-03-30 15:14 UTC, Thomas Wiest
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiest 2007-09-15 19:53:32 UTC


---- Reported by vargaz@gmail.com 2006-03-30 08:14:14 MST ----

Currently, most calls to Report.Warning and Report.Error methods in mcs
go to the 'params' versions of these methods, meaning the generated code
will have to create a (usually 0 or 1) length array, and initialize it.
The attached patch avoids that by adding some overloads to these methods. It
reduces the native code generated by the JIT for mcs by about 10KB on x86.



---- Additional Comments From vargaz@gmail.com 2006-03-30 08:14:41 MST ----

Created an attachment (id=169514)
patch




---- Additional Comments From rharinath@novell.com 2006-03-30 21:22:57 MST ----

The one- and two- argument Format variants can probably directly use
the corresponding String.Format rather than allocating the arrays
here, I think:

  -  String.Format (fmt, new string [] { arg1, arg2 })
  +  String.Format (fmt, arg1, arg2)




---- Additional Comments From rharinath@novell.com 2006-04-03 06:59:22 MST ----

Committed as SVN r58930, with some minor changes.

Imported an attachment (id=169514)

Unknown operating system unknown. Setting to default OS "Other".