Bugzilla – Bug 320711
[PATH] Add overloads to Report.Warning/Error methods to reduce code size
Last modified: 2007-09-15 21:24:23 UTC
---- Reported by vargaz@gmail.com 2006-03-30 08:14:14 MST ---- Currently, most calls to Report.Warning and Report.Error methods in mcs go to the 'params' versions of these methods, meaning the generated code will have to create a (usually 0 or 1) length array, and initialize it. The attached patch avoids that by adding some overloads to these methods. It reduces the native code generated by the JIT for mcs by about 10KB on x86. ---- Additional Comments From vargaz@gmail.com 2006-03-30 08:14:41 MST ---- Created an attachment (id=169514) patch ---- Additional Comments From rharinath@novell.com 2006-03-30 21:22:57 MST ---- The one- and two- argument Format variants can probably directly use the corresponding String.Format rather than allocating the arrays here, I think: - String.Format (fmt, new string [] { arg1, arg2 }) + String.Format (fmt, arg1, arg2) ---- Additional Comments From rharinath@novell.com 2006-04-03 06:59:22 MST ---- Committed as SVN r58930, with some minor changes. Imported an attachment (id=169514) Unknown operating system unknown. Setting to default OS "Other".