Bug 322130 (MONO79424) - [PATCH] MonoLoaderError cleared to soon in loader.c
Summary: [PATCH] MonoLoaderError cleared to soon in loader.c
Status: RESOLVED FIXED
Alias: MONO79424
Product: Mono: Runtime
Classification: Mono
Component: misc (show other bugs)
Version: 1.0
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Mono Bugs
QA Contact: Mono Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-17 17:20 UTC by Gert Driesen
Modified: 2007-09-15 21:24 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Fix (1017 bytes, patch)
2006-09-17 17:21 UTC, Thomas Wiest 		Details | Diff
(gzipped) tar containing repro (1.37 KB, application/x-gzip)
2006-09-17 17:27 UTC, Thomas Wiest 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiest 2007-09-15 20:10:20 UTC 


---- Reported by gert.driesen@pandora.be 2006-09-17 10:20:02 MST ----

The MonoLoaderError is cleared too soon in 
mono_loader_error_prepare_exception, and as a result 
FileNotFoundException.FileName is always set to an empty string (for 
assembly loader errors).

Let me know if it's ok to commit the patch.



---- Additional Comments From gert.driesen@pandora.be 2006-09-17 10:21:30 MST ----

Created an attachment (id=170493)
Fix




---- Additional Comments From gert.driesen@pandora.be 2006-09-17 10:26:25 MST ----

I've also attached a repro for this issue.

To reproduce:

1. Extract the (gzipped) tar archive.
2. cd https://bugzilla.novell.com/show_bug.cgi?id=MONO79424
3. make

Expected result:

(bunch of warnings)
OK

Actual result:

(bunch of warnings)
FileNotFoundException.FileName does not match.
expected: library, Version=1.2.3.4, Culture=neutral
but was: 




---- Additional Comments From gert.driesen@pandora.be 2006-09-17 10:27:04 MST ----

Created an attachment (id=170494)
(gzipped) tar containing repro




---- Additional Comments From vargaz@gmail.com 2006-09-17 11:19:25 MST ----

This is ok to check in.




---- Additional Comments From gert.driesen@pandora.be 2006-09-18 11:33:20 MST ----

Fixed in svn (revision 65580).



---- Additional Comments From gert.driesen@pandora.be 2007-03-06 16:14:36 MST ----

There's been a regression for this issue. The FileName in the 
FileNotFoundException is now again not set.



---- Additional Comments From vargaz@gmail.com 2007-03-06 17:13:24 MST ----

Somebody reverted it by accident. Feel free to check it in again.
 



---- Additional Comments From gert.driesen@pandora.be 2007-04-28 10:21:40 MST ----

Working fine now.

Imported an attachment (id=170493)
Imported an attachment (id=170494)

Unknown operating system unknown. Setting to default OS "Other".