Bugzilla – Bug 323072
[PATCH] support for generic types & methods in remoting interfaces
Last modified: 2007-09-15 21:24:46 UTC
---- Reported by robertj@gmx.net 2006-12-28 00:02:55 MST ---- The patches consists of: corlib/System.Runtime.Serialization.Formatters.Binary: - documentation update of the binary serialization format - BinaryCommon.Methodflags update - MessageFormater update - ObjectWriter.cs, ObjectReader.cs: MS.NET serializes generic parameters as System.RuntimeType objects. Because Mono doesn't know this type, the binary formatter must map between System.RuntimeType and System.MonoType. This (maybe questionable) change is only required for interoperability. I tried to make the patch less intrusive by checking the serialization context. corlib/System.Runtime.Remoting.Messaging: - MethodCall: fix a buglet that prevented CastTo() to handle closed generic types correctly. - MethodCall: add support for generic method arguments - ReturnMessage: fix for https://bugzilla.novell.com/show_bug.cgi?id=MONO80371. System.Runtime.Remoting/Tests: - GenericTest: unit tests. I'll try later to integrate this test into the existing tests, if possible. ---- Additional Comments From robertj@gmx.net 2006-12-28 00:03:41 MST ---- Created an attachment (id=171182) corlib_remoting_20.diff ---- Additional Comments From robertj@gmx.net 2006-12-28 00:13:08 MST ---- Note that the SOAP formatter remains unchanged because MS.NET's own formatter doesn't support generic types. Mono's supports open generic types, but I'll add a check&trow for this to match MS. ---- Additional Comments From robertj@gmx.net 2006-12-28 00:22:06 MST ---- Created an attachment (id=171183) System.Runtime.Remoting.Test.GenericTest.cs - new file ---- Additional Comments From robertj@gmx.net 2006-12-28 00:23:29 MST ---- Created an attachment (id=171184) System.Runtime.Remoting_test.dll.sources.diff ---- Additional Comments From lluis@ximian.com 2007-01-08 09:00:11 MST ---- The patch looks ok to me. Feel free to commit. Thanks! ---- Additional Comments From robertj@gmx.net 2007-01-08 09:09:42 MST ---- May I normalize the line endings before committing the changes? ---- Additional Comments From miguel@ximian.com 2007-01-08 14:34:16 MST ---- Robert, that sounds like a good idea. Go ahead. ---- Additional Comments From robertj@gmx.net 2007-01-08 20:45:32 MST ---- Fixed in SVN r70683-70684. ---- Additional Comments From robertj@gmx.net 2007-01-08 20:46:47 MST ---- Forget to close. This bug blocked bug(s) 78882. Imported an attachment (id=171182) Imported an attachment (id=171183) Imported an attachment (id=171184)