Bug 323095 (MONO80406) - [PATCH] TcpChannel: OneWay messages lost / interoperability
Summary: [PATCH] TcpChannel: OneWay messages lost / interoperability
Status: RESOLVED FIXED
Alias: MONO80406
Product: Mono: Runtime
Classification: Mono
Component: remoting (show other bugs)
Version: 1.2
Hardware: Other All
: P3 - Medium : Major
Target Milestone: ---
Assignee: Lluis Sanchez
QA Contact: Mono Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-30 12:26 UTC by Robert Jordan
Modified: 2007-09-15 21:24 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
bug-80406.diff (3.73 KB, patch)
2006-12-30 12:29 UTC, Thomas Wiest 		Details | Diff
bug-80406-test-case.cs (1.31 KB, text/plain)
2006-12-30 12:37 UTC, Thomas Wiest 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiest 2007-09-15 20:21:35 UTC 


---- Reported by robertj@gmx.net 2006-12-30 05:26:53 MST ----

The patch fixes 2 issues:

1) OneWay messages must be marked with 0x01 in the message request
   header, otherwise MS.NET 1.1 has a bad time handling them: it partially
   drops the messages and it swallows NREs according to MS.NET's
   performance counters and WinDbg.

2) when TcpServerChannel.cs (ProcessMessages) is flushing the buffer,
   pending OneWay and async messages are partially lost because the
   buffer is still "on the way" down the sink.



---- Additional Comments From robertj@gmx.net 2006-12-30 05:29:07 MST ----

Created an attachment (id=171207)
bug-80406.diff




---- Additional Comments From robertj@gmx.net 2006-12-30 05:37:29 MST ----

Created an attachment (id=171208)
bug-80406-test-case.cs




---- Additional Comments From lluis@ximian.com 2007-01-08 09:02:58 MST ----

The patch looks ok to me. Feel free to commit. Thanks!



---- Additional Comments From robertj@gmx.net 2007-01-08 20:49:25 MST ----

Fixed in SVN r70685.


Imported an attachment (id=171207)
Imported an attachment (id=171208)