Bug 324869 (MONO82199) - dropdown history in search dialog
Summary: dropdown history in search dialog
Status: RESOLVED FIXED
Alias: MONO82199
Product: MonoDevelop
Classification: Mono
Component: texteditor (show other bugs)
Version: 0.12
Hardware: Other Linux
: P3 - Medium : Normal
Target Milestone: ---
Assignee: MD Bugs
QA Contact: MD Bugs
URL:
Whiteboard:
Keywords: keynav
Depends on:
Blocks:
 
Reported: 2007-07-26 23:55 UTC by Victor Sergienko
Modified: 2007-09-15 21:23 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
Changes search/replace Entries to ComboBoxEntries (470.54 KB, patch)
2007-07-30 23:13 UTC, Thomas Wiest
Details | Diff
Updated for steticization of MonoDevelop.Ide (22.22 KB, patch)
2007-08-08 22:26 UTC, Thomas Wiest
Details | Diff
Same as previous, but with ChangeLog (23.13 KB, patch)
2007-08-08 22:35 UTC, Thomas Wiest
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiest 2007-09-15 20:45:29 UTC


---- Reported by singalen@gmail.com 2007-07-26 16:55:29 MST ----

If search dialog had a dropdown history in Find field, it would be possible
to easily return to previous search by pressing Ctrl-F, Down.
Now there's no way to go back some past searches at all.



---- Additional Comments From taktaktaktaktaktaktaktaktaktak@gmail.com 2007-07-30 16:13:55 MST ----

Created an attachment (id=172353)
Changes search/replace Entries to ComboBoxEntries




---- Additional Comments From fejj@novell.com 2007-07-30 16:55:40 MST ----

+		private const char historySeparator = (char) 10;

would be better to use the char literal


I'll try to remember to finish reviewing the patch tomorrow/test it
out/etc (if Lluis doesn't get to it before me) but I think it looks ok



---- Additional Comments From taktaktaktaktaktaktaktaktaktak@gmail.com 2007-07-31 12:37:24 MST ----

Actually, the (char)10 is from the existing code in the ReplaceDialog;
I kept it for consistency, since Find/FindInFiles are using the same
history list.  Can change both if necessary.



---- Additional Comments From taktaktaktaktaktaktaktaktaktak@gmail.com 2007-08-08 15:26:02 MST ----

Created an attachment (id=172354)
Updated for steticization of MonoDevelop.Ide




---- Additional Comments From taktaktaktaktaktaktaktaktaktak@gmail.com 2007-08-08 15:35:29 MST ----

Created an attachment (id=172355)
Same as previous, but with ChangeLog




---- Additional Comments From lluis@ximian.com 2007-08-13 06:55:58 MST ----

Patch applied. Thanks!

Imported an attachment (id=172353)
Imported an attachment (id=172354)
Imported an attachment (id=172355)